Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 6120 #6306

Merged
merged 1 commit into from Aug 14, 2023
Merged

Improve 6120 #6306

merged 1 commit into from Aug 14, 2023

Conversation

theNded
Copy link
Contributor

@theNded theNded commented Aug 11, 2023

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

#6120 works but is less pythonic. Since I cannot directly edit their branch, I will make a tiny new PR instead.


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Aug 11, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey merged commit c46e64a into isl-org:master Aug 14, 2023
36 checks passed
@ssheorey
Copy link
Member

Thanks to the original author @jayanthd26 and review from @akash02ita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants