Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .desktop entry when installing in a UNIX system #6599

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

EwingKang
Copy link
Contributor

@EwingKang EwingKang commented Jan 12, 2024

Fix the path to the default Open3D application when installing to a custom path.

Type

  • Bug fix (non-breaking change which fixes an issue):
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Motivation and Context

When installing to a custom path using cmake on the Ubuntu 22.04, desktop entry is not added correctly. The "Show Applications" button does not show the default Open3D viewer application.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

When building and installing to a custom path, the .desktop has incorrect path to the binary. It causes missing entry when using the application listing functions.
After this patch, it is successfully detected by the desktop system
image

* Fix the path to the default Open3D application when installing to a custom path.
Copy link

update-docs bot commented Jan 12, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@benjaminum benjaminum merged commit 0cf605f into isl-org:main Jan 17, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants