Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successfully built with llvm-19, imgui-1.90.6 and remove bug from std::move. #6788

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jiapei100
Copy link

@jiapei100 jiapei100 commented May 9, 2024

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented May 9, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey requested a review from errissa May 12, 2024 06:46
@ssheorey
Copy link
Member

Hi @jiapei100 thanks for submitting this PR! Please describe the bug that you fixed, with a way to reproduce it in the current version. [Especially about std::move].

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jiapei100 Thanks for the updates. Can you also:

  • update 3rdparty/imgui/imgui.cmake to latest (1.90.6)
  • Test visualization examples (especially all_widgets.py) on your computer and let us know the OS and hardware that you tested on.
  • pip install clang-format~=10.0 and run make apply-style to fix the style.

/usr/lib/llvm-10/lib
/usr/lib/llvm-9/lib
/usr/lib/llvm-8/lib
/usr/lib/llvm-7/lib
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jiapei100 with this change, it will not build with older llvm / libc++ versions. Why did you remove support for older LLVM versions?

@ssheorey ssheorey added the status / needs info Waiting for information from reporter / author label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status / needs info Waiting for information from reporter / author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants