Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dummy semicolon after empty functions #908

Merged
merged 1 commit into from Apr 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Expand Up @@ -27,7 +27,7 @@ If applicable, add screenshots to help explain your problem.

**Environment (please complete the following information):**
- OS: [e.g. OSX Mojave, Ubuntu 16.04, Windows 10.0]
- Python version:
- Python version:
- Open3D version:
- Is this remote workstation?: yes or no
- How did you install Open3D?: pip or conda or build_from_source (provide build method, such as gcc, xcode, visual studio, and so on)
Expand Down
6 changes: 3 additions & 3 deletions examples/Python/Basic/mesh_voxelization.py
Expand Up @@ -40,7 +40,7 @@ def depth_to_pcd(depth, intrinsic, extrinsic, w, h):
uu_vector = uu.ravel()
vv_vector = vv.ravel()
depth_vector = np.asarray(depth, dtype=np.float32).ravel()

uvd = np.asarray([uu_vector * depth_vector,
vv_vector * depth_vector,
depth_vector])
Expand All @@ -66,7 +66,7 @@ def preprocess(model):
print("visualize model")
draw_geometries([model])

# rescale geometry
# rescale geometry
sphere = preprocess(sphere)
model = preprocess(model)

Expand All @@ -92,7 +92,7 @@ def preprocess(model):
centers_pts[i,:] = c[:3]
i += 1
ctr.convert_from_pinhole_camera_parameters(param)

# capture depth image and make a point cloud
vis.poll_events()
vis.update_renderer()
Expand Down
4 changes: 2 additions & 2 deletions src/Open3D/Geometry/HalfEdgeTriangleMesh.h
Expand Up @@ -59,7 +59,7 @@ class HalfEdgeTriangleMesh : public TriangleMesh {

public:
HalfEdgeTriangleMesh()
: TriangleMesh(Geometry::GeometryType::HalfEdgeTriangleMesh){};
: TriangleMesh(Geometry::GeometryType::HalfEdgeTriangleMesh) {}

/// Compute and update half edges, half edge can only be computed if the
/// mesh is a manifold. Returns true if half edges are computed.
Expand Down Expand Up @@ -87,7 +87,7 @@ class HalfEdgeTriangleMesh : public TriangleMesh {
HalfEdgeTriangleMesh operator+(const HalfEdgeTriangleMesh &mesh) const;

protected:
HalfEdgeTriangleMesh(Geometry::GeometryType type) : TriangleMesh(type){};
HalfEdgeTriangleMesh(Geometry::GeometryType type) : TriangleMesh(type) {}
void RemoveDuplicatedVertices() override;
void RemoveDuplicatedTriangles() override;
void RemoveNonManifoldVertices() override;
Expand Down
4 changes: 2 additions & 2 deletions src/Open3D/Geometry/Image.h
Expand Up @@ -57,8 +57,8 @@ class Image : public Geometry2D {
};

public:
Image() : Geometry2D(Geometry::GeometryType::Image){};
~Image() override{};
Image() : Geometry2D(Geometry::GeometryType::Image) {}
~Image() override {}

public:
void Clear() override;
Expand Down
4 changes: 2 additions & 2 deletions src/Open3D/Geometry/PointCloud.h
Expand Up @@ -47,8 +47,8 @@ class RGBDImage;

class PointCloud : public Geometry3D {
public:
PointCloud() : Geometry3D(Geometry::GeometryType::PointCloud){};
~PointCloud() override{};
PointCloud() : Geometry3D(Geometry::GeometryType::PointCloud) {}
~PointCloud() override {}

public:
void Clear() override;
Expand Down
4 changes: 2 additions & 2 deletions src/Open3D/Geometry/RGBDImage.h
Expand Up @@ -37,9 +37,9 @@ namespace geometry {
/// If you have other format, convert it first.
class RGBDImage {
public:
RGBDImage(){};
RGBDImage() {}
RGBDImage(const Image &color, const Image &depth)
: color_(color), depth_(depth){};
: color_(color), depth_(depth) {}
~RGBDImage() {
color_.Clear();
depth_.Clear();
Expand Down
6 changes: 3 additions & 3 deletions src/Open3D/Geometry/TriangleMesh.h
Expand Up @@ -38,8 +38,8 @@ namespace geometry {

class TriangleMesh : public Geometry3D {
public:
TriangleMesh() : Geometry3D(Geometry::GeometryType::TriangleMesh){};
~TriangleMesh() override{};
TriangleMesh() : Geometry3D(Geometry::GeometryType::TriangleMesh) {}
~TriangleMesh() override {}

public:
void Clear() override;
Expand All @@ -66,7 +66,7 @@ class TriangleMesh : public Geometry3D {

protected:
// Forward child class type to avoid indirect nonvirtual base
TriangleMesh(Geometry::GeometryType type) : Geometry3D(type){};
TriangleMesh(Geometry::GeometryType type) : Geometry3D(type) {}
virtual void RemoveDuplicatedVertices();
virtual void RemoveDuplicatedTriangles();
virtual void RemoveNonManifoldVertices();
Expand Down
4 changes: 2 additions & 2 deletions src/Open3D/Geometry/VoxelGrid.h
Expand Up @@ -40,8 +40,8 @@ class TriangleMesh;

class VoxelGrid : public Geometry3D {
public:
VoxelGrid() : Geometry3D(Geometry::GeometryType::VoxelGrid){};
~VoxelGrid() override{};
VoxelGrid() : Geometry3D(Geometry::GeometryType::VoxelGrid) {}
~VoxelGrid() override {}

public:
void Clear() override;
Expand Down
Expand Up @@ -49,7 +49,7 @@ class GlobalOptimizationOption {
preference_loop_closure_ =
preference_loop_closure < 0.0 ? 1.0 : preference_loop_closure;
};
~GlobalOptimizationOption(){};
~GlobalOptimizationOption() {}

public:
/// See reference list in GlobalOptimization.h
Expand Down Expand Up @@ -97,7 +97,7 @@ class GlobalOptimizationConvergenceCriteria {
? 1. / 3.
: lower_scale_factor;
};
~GlobalOptimizationConvergenceCriteria(){};
~GlobalOptimizationConvergenceCriteria() {}

public:
/// maximum iteration number for iterative optmization module.
Expand Down
4 changes: 2 additions & 2 deletions src/Open3D/Registration/PoseGraph.h
Expand Up @@ -38,7 +38,7 @@ namespace registration {
class PoseGraphNode : public utility::IJsonConvertible {
public:
PoseGraphNode(const Eigen::Matrix4d &pose = Eigen::Matrix4d::Identity())
: pose_(pose){};
: pose_(pose) {}
~PoseGraphNode();

public:
Expand All @@ -63,7 +63,7 @@ class PoseGraphEdge : public utility::IJsonConvertible {
transformation_(transformation),
information_(information),
uncertain_(uncertain),
confidence_(confidence){};
confidence_(confidence) {}
~PoseGraphEdge();

public:
Expand Down
4 changes: 2 additions & 2 deletions src/Open3D/Visualization/Utility/ColorMap.h
Expand Up @@ -43,8 +43,8 @@ class ColorMap {
};

public:
ColorMap(){};
virtual ~ColorMap(){};
ColorMap() {}
virtual ~ColorMap() {}

public:
/// Function to get a color from a value in [0..1]
Expand Down