Ivo/RTSP server fixes #185
Conversation
izivkov
commented
Apr 30, 2021
izivkov
commented
- Delay starting the RTSP client 1 second to improve staring issues.
- Move setting resolution from RtspServer to PhoneController
- Select Nearby connection when WiFi is turned off.
# Conflicts: # android/app/src/main/java/org/openbot/env/RtspServer.java # android/controller/python/keyboard-controller-ui.py
# Conflicts: # android/app/src/main/java/org/openbot/env/RtspServer.java # android/controller/python/keyboard-controller-ui.py
- Move setting resolution from RtspServer to PhoneController - Select Nearby connection when WiFi is turned off.
This file was refactored, moved to `root/python` and is now called `keyboard-pygame.py`
| @@ -5,10 +5,10 @@ | |||
| import android.view.TextureView; | |||
|
|
|||
| public interface IVideoServer { | |||
| void startServer(); | |||
There was a problem hiding this comment.
Why is this no longer needed?
There was a problem hiding this comment.
I see, this seems to be handled now in RTSP server with private void startServer and is not part of the interface anymore.
There was a problem hiding this comment.
Why is this no longer needed?
The server is started implicitly now when all the input conditions are met. Take a look at how AndGate is used.
There was a problem hiding this comment.
On second thought, maybe we should keep this in the interface. Looks like a method you would normally use. I think I will change it back.
Yes, the name of the branch is misleading. This was my intent, but as I described in Slack, ran into problems with dynamically creating surfaces. The description of the MR is correct. I will see if I can change the name of the brarch. |
|
Ok, makes sense. Will test and then merge. |
