Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model management #188

Merged
merged 42 commits into from
May 6, 2021
Merged

Model management #188

merged 42 commits into from
May 6, 2021

Conversation

dhruv2295
Copy link
Contributor

modal management screen to edit model details and add download it.

@thias15
Copy link
Collaborator

thias15 commented May 1, 2021

  • Add option to delete a model
  • If user adds a model, the file picker opens and user selects a file. We should then show the settings dialog with default settings for autopilot filled in rather than adding directly with that assumption. User can edit or confirm. This way they could also add other models in principle.

@thias15
Copy link
Collaborator

thias15 commented May 4, 2021

In the autopilot and object detector screen the models are not loaded correctly anymore. I guess because of the extension.

Also, when you add a model from storage, the toast message appears before clicking "Done". This is confusing. Lastly, there is an issue with Yolov4. After downloading, if I click on the model to edit it the app crashes. The Yolov4 detector works in the object nav screen, just not in the model management screen. When I click on the model to edit it, the app crashes. Please check.

@thias15
Copy link
Collaborator

thias15 commented May 4, 2021

In the autopilot and object detector screen the models are not loaded correctly anymore. I guess because of the extension.

So it turns out the models did not run for me due to permissions. If I deny camera permission in another screen, it won't ask again and the models just don't work. There is another issue to clean up the permission handling across the app. Let's fix it then. For now we can assume that the user will give the camera permission.

Copy link
Collaborator

@thias15 thias15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the autopilot screen, models can be added, but they do not show up in the model management and also not in the drop-down.

@@ -580,7 +588,6 @@ private void setModel(Model model) {
if (this.model != model) {
Timber.d("Updating model: %s", model);
this.model = model;
preferencesManager.setAutoPilotModel(model.toString());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to still maintain the previously selected model.

@thias15 thias15 merged commit ac27fbf into isl-org:master May 6, 2021
This was linked to issues May 6, 2021
@dhruv2295 dhruv2295 deleted the modelManagement branch May 19, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neural networks config AI model management fragment
2 participants