-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model management #188
Model management #188
Conversation
update config on model download
…nges to config file
|
2. focus edit model name on edit button click
In the autopilot and object detector screen the models are not loaded correctly anymore. I guess because of the extension. Also, when you add a model from storage, the toast message appears before clicking "Done". This is confusing. Lastly, there is an issue with Yolov4. After downloading, if I click on the model to edit it the app crashes. The Yolov4 detector works in the object nav screen, just not in the model management screen. When I click on the model to edit it, the app crashes. Please check. |
So it turns out the models did not run for me due to permissions. If I deny camera permission in another screen, it won't ask again and the models just don't work. There is another issue to clean up the permission handling across the app. Let's fix it then. For now we can assume that the user will give the camera permission. |
2. edit model screen class type selection fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the autopilot screen, models can be added, but they do not show up in the model management and also not in the drop-down.
@@ -580,7 +588,6 @@ private void setModel(Model model) { | |||
if (this.model != model) { | |||
Timber.d("Updating model: %s", model); | |||
this.model = model; | |||
preferencesManager.setAutoPilotModel(model.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to still maintain the previously selected model.
modal management screen to edit model details and add download it.