Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ivo/improve stability when controller is restarted #247

Merged
merged 9 commits into from Jan 1, 2022
Merged

Ivo/improve stability when controller is restarted #247

merged 9 commits into from Jan 1, 2022

Conversation

izivkov
Copy link
Contributor

@izivkov izivkov commented Dec 27, 2021

Androd Controller:

  • Can now restart Android controller multiple times and connect to Bot without restating the Bot app.

NodeJS:

  • Can reload page, close and open page without a need to restart the Bot app or the NodeJS server
  • Refactored JS code to use functions instead of the less-common Classes. Streamlined code.
  • Added ConnectionManager function to localise all connection-related code.

thias15
thias15 reviewed Jan 1, 2022
View reviewed changes
Copy link
Collaborator

@thias15 thias15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to test.

@thias15 thias15 merged commit b5e9038 into isl-org:master Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thias15 thias15 thias15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izivkov @thias15