Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update collision thresholds #265

Merged
merged 2 commits into from Mar 6, 2022
Merged

Conversation

thias15
Copy link
Collaborator

@thias15 thias15 commented Mar 3, 2022

No description provided.

@thias15 thias15 self-assigned this Mar 3, 2022
@thias15 thias15 added this to In progress in OpenBot via automation Mar 3, 2022
Copy link
Collaborator

@quentin-leboutet quentin-leboutet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the proposed changes correct the bumper behaviour on the new RTR vehicle. I also did a rapid test on one of the old RTR vehicles and got -- as expected from code line 803 -- the "??" output on every bumpers, except for the "Left Back". I approve the changes.

@thias15 thias15 merged commit d4362e6 into master Mar 6, 2022
OpenBot automation moved this from In progress to Done Mar 6, 2022
@thias15 thias15 deleted the thias15/update-collision-thresholds branch March 15, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
OpenBot
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants