Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle screen #296

Merged
merged 20 commits into from
Nov 18, 2022
Merged

Vehicle screen #296

merged 20 commits into from
Nov 18, 2022

Conversation

thias15
Copy link
Collaborator

@thias15 thias15 commented Oct 14, 2022

New screen that shows which vehicle is connected and what features it supports (based on firmware info).

Copy link
Collaborator Author

@thias15 thias15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve merge conflict

@thias15
Copy link
Collaborator Author

thias15 commented Nov 16, 2022

@quentin-leboutet please test and review.

Copy link
Collaborator

@quentin-leboutet quentin-leboutet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on RTR_TT, RTR_520, MTV and RC_TRUCK. This is minor but maybe the LED slider should be greyed out or set to 0 when LEDs are not available on the vehicle? I'm also gonna generate a gif for the new design of the RC_TRUCK. Otherwise looks great !

@thias15 thias15 merged commit 52e8f20 into master Nov 18, 2022
@thias15 thias15 deleted the thias15/vehicle-screen branch November 23, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants