Adjust robot speed by a estimated distancefactor. #311
Conversation
The distancefactor is estimated from width of the tracking box, assuming that the tracking box is lage if close to tracked object and apply the factor to the speed control vars.
|
Hi @reger24. Thanks for your contribution. Using only the width of the bounding box may be quite specific to the object of choice and the orientation of the phone. For example the ratio between bounding box width and frame width would be quite different if the phone is in landscape or portrait mode and also very different if you track a person vs. a car. I think it would probably be better to use the area (width*height) instead. |
|
Also, the style check did not pass. You can fix the style by navigating to the android folder and then executing |
|
Hi @thias15 , your point with the orientation dependency is very likely true (as I tested & concentrated on landscape). |
|
@reger24 sounds good. You can just push updates to your branch and the PR will be updated automatically. |
|
fyi: both, the current (box-width) and the suggested (box-area) adjustment work best in landscape mode, not so well in portrait mode, but in landscape I find it relative nice/ok. |
…k box area in relation to screen area, assuming that the tracking box is lage if close to tracked object/person and apply the factor to the speed control vars. Below a threshold the robot will stop, above a threshold robot will follow with predefined (UI) speed. Restriction: as it works best if phone is in landscape mode, the robot will only use the stop threshold in portrait but not adjust speed.
applyStyle made tow (grrr) changes
|
Hi @reger24. Sorry for the delay, very busy few months. This looks good, but since it does not work reliably in portrait mode for some classes, how about making this scaling optional? There could be a |
…fault to false) - implemented getter/setter for class SharedPreferencesManager - added a "Option" descrition to readme.md
reduce screenshot size
|
Sorry for being so picky. But ideally the dynamic speed toggle would be only in the ObjectNav GUI since it's specific to that. The settings menu is meant more for global settings like permissions, video streaming mode, robot connection, etc. |
|
No problem (was not completley convinced myself about the best place of the option switch), for now I'll try to squeeze it to ObjectNav's bottom sheet - and update PR. P.S.
|
…racking bottom sheets (remove from generals Settings)
Adjust robot speed (in object tracking mode) by a distance factor estimated from the width of the tracking box
assuming that the tracking box is lage if close to tracked object and apply the factor to the speed control vars.
#310