Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Android API Level from 29 to 32. #333

Merged
merged 6 commits into from Feb 15, 2023

Conversation

sparsh3dwe
Copy link
Collaborator

  • Upgrading android api level from 29 to 32.
  • Changing default logs and files output location to Documents.
  • Upgrading Gradle version from 7.0.4 to 7.4.0

Copy link
Collaborator

@thias15 thias15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Need to test. Can recordings be accessed directly from file storarge?

@sparsh3dwe
Copy link
Collaborator Author

Looks good. Need to test. Can recordings be accessed directly from file storarge?

Yes, they are directly accessible from documents

@thias15 thias15 self-assigned this Feb 14, 2023
@thias15 thias15 added this to In progress in OpenBot via automation Feb 14, 2023
@thias15
Copy link
Collaborator

thias15 commented Feb 14, 2023

Tested, works as expected. The only issue is that the app is not able to find the node.js server for uploading data. But this seems to be unrelated to this PR.

OpenBot automation moved this from In progress to In review Feb 15, 2023
@thias15 thias15 merged commit ca19b39 into isl-org:master Feb 15, 2023
OpenBot automation moved this from In review to Done Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OpenBot
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants