Fix GitHub token in android upload release action #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This GITHUB_TOKEN was previously included with the assumption that a repo either has GH_TOKEN or GITHUB_TOKEN, but it is actually possibly that both will be available, which will would make the upload fail. Also, the other actions in the repo just use GH_TOKEN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, very small PR here because I realized a mistake in my previous PR(#74 ).
The android apk upload would not work if the GITHUB_TOKEN as well as the GH_TOKEN exist, so I removed the GITHUB_TOKEN usage.
This is also more in line with the the other yml files in the repo.
I added GH_TOKEN in my fork and created a release to test the action run.
Also, I saw I used CRLF line endings, so I changed that to LF.