Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chinese README files. #84

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Update Chinese README files. #84

merged 4 commits into from
Oct 15, 2020

Conversation

leegang
Copy link
Contributor

@leegang leegang commented Oct 15, 2020

Update Chinese README files.

@leegang
Copy link
Contributor Author

leegang commented Oct 15, 2020

#82

@leegang leegang mentioned this pull request Oct 15, 2020
Closed
@thias15
Copy link
Collaborator

thias15 commented Oct 15, 2020 •
edited

This is great! Just two minor comments. I noticed for example in the cad folders the Chinese README is called README copy.md so the linking does not work. Also the links inside the Chinese doc should link directly to the Chinese version README files. Could you fix this please. If you just push to your branch, the PR is updated automatically. Thanks for your contribution!

@leegang
Copy link
Contributor Author

leegang commented Oct 15, 2020

This is great! Just two minor comments. I noticed for example in the cad folders the Chinese README is called README copy.md so the linking does not work. Also the links inside the Chinese doc should link directly to the Chinese version README files. Could you fix this please. If you just push to your branch, the PR is updated automatically. Thanks for your contribution!

OK, will fix them.

@thias15 thias15 linked an issue Oct 15, 2020 that may be closed by this pull request
Update Chinese README files. #82
Closed
@thias15 thias15 merged commit a3a4ed2 into isl-org:master Oct 15, 2020
@thias15
Copy link
Collaborator

thias15 commented Oct 15, 2020

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Chinese README files.
2 participants
@leegang @thias15