Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Only enable default prefetching for links with 'as' #935

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Web: Only enable default prefetching for links with 'as' #935

merged 1 commit into from
Sep 22, 2020

Conversation

arnorhs
Copy link
Contributor

@arnorhs arnorhs commented Sep 20, 2020

Description

Only enabling default prefetching of JS bundles, when the target bundle is known (when the 'as' prop is set on the Link component)

Note: This (along with most Link references) will have to updated anyways after next >= 9.5.3

What

Changes the NextLink generic component in the ui-core (which is probably not the right place for the component in the first place)

Why

The console spits out a bunch of 404 not founds for links defined using , but without specifying an 'as' prop (to know what kind of component it is supposed to link to)

Screenshots / Gifs

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against master before asking for a review

@stefanhar stefanhar merged commit 130c2a3 into island-is:master Sep 22, 2020
@stefanhar stefanhar deleted the web_link_prefetching branch September 22, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants