You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sanderpick, before we merge in wouldn't mind a second look. Here are some questions I could use your expertise on:
For our top climbers, we'll be getting in about 90% of their climbs. The missing climbs are ones we have no crag information for. Acceptable for a first pass?
Not checking for duplicates - do we care?
Not creating events for any ascent or tick added - do we care? I might create an automatic event post to celebrate the import.
For 1000 routes/boulders, import can take a minute. This is primarily due to weather request per crag. Acceptable?
Anyway, try it out on your account (150+ boulders, 1 route!) and tell me what you think. You can get to import from the settings page or by going to /import.
hell yes. I'm getting booted from my cafe. will check tomorrow evening. this is huge!
On Monday, January 5, 2015 at 7:40 PM, Eyal Cohen wrote:
This PR covers issue #88 (#88) @sanderpick (https://github.com/sanderpick), before we merge in wouldn't mind a second look. Here are some questions I could use your expertise on:
For our top climbers, we'll be getting in about 90% of their climbs. The missing climbs are ones we have no crag information for. Acceptable for a first pass?
Not checking for duplicates - do we care?
Not creating events for any ascent or tick added - do we care? I might create an automatic event post to celebrate the import.
For 1000 routes/boulders, import can take a minute. This is primarily due to weather request per crag. Acceptable?
Anyway, try it out on your account (150+ boulders, 1 route!) and tell me what you think. You can get to import from the settings page or by going to /import.
You can merge this Pull Request by running
git pull https://github.com/The-Island/island-app feature/8a
Or view, comment on, or merge it at: #90
Commit Summary
wip scraper
Get all ascents from 8a
All gravy baby
wip
more wip
wip
Getting closer
Working, finally
style and tweaks
Boulder / Route counts on tick list
Some style tweaks
tweaks
Add import button to settings
For our top climbers, we'll be getting in about 90% of their climbs. The missing climbs are ones we have no crag information for. Acceptable for a first pass?
yep yep
Not checking for duplicates - do we care?
nope nope
Not creating events for any ascent or tick added - do we care? I might create an automatic event post to celebrate the import.
that would be sweet
For 1000 routes/boulders, import can take a minute. This is primarily due to weather request per crag. Acceptable?
yep yep!
Anyway, try it out on your account (150+ boulders, 1 route!) and tell me what you think. You can get to import from the settings page or by going to /import.
You can merge this Pull Request by running
git pull https://github.com/The-Island/island-app feature/8a
Or view, comment on, or merge it at: #90
Commit Summary
wip scraper
Get all ascents from 8a
All gravy baby
wip
more wip
wip
Getting closer
Working, finally
style and tweaks
Boulder / Route counts on tick list
Some style tweaks
tweaks
Add import button to settings
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers issue #88
@sanderpick, before we merge in wouldn't mind a second look. Here are some questions I could use your expertise on:
Anyway, try it out on your account (150+ boulders, 1 route!) and tell me what you think. You can get to import from the settings page or by going to /import.