Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon is missing a dummy app for testing #30

Closed
villander opened this issue Apr 16, 2016 · 8 comments
Closed

Addon is missing a dummy app for testing #30

villander opened this issue Apr 16, 2016 · 8 comments
Assignees

Comments

@villander
Copy link

➜ ember-cordova git:(master) ember -v
version: 2.3.0
node: 4.0.0
os: darwin x64
➜ ember-cordova git:(master) node -v
v4.0.0
➜ ember-cordova git:(master) npm -v
3.8.6
➜ ember-cordova git:(master)

➜  ember-cordova git:(master) ember s
version: 2.3.0
DEPRECATION: this.pickFiles is deprecated, please use broccoli-funnel directly instead  [addon: qunit-bdd]
broccoli-funnel does not support `files:` option with globs, please use `include:` instead
DEPRECATION: this.mergeTrees is deprecated, please use broccoli-merge-trees directly instead  [addon: qunit-bdd]
Attempting to watch missing directory: tests/dummy/app
Error: Attempting to watch missing directory: tests/dummy/app
    at EventEmitter.Watcher_addWatchDir [as addWatchDir] (/Users/flama/Projects/ember-cordova/node_modules/broccoli-sane-watcher/index.js:90:11)
    at /Users/flama/Projects/ember-cordova/node_modules/broccoli/lib/builder.js:94:35
    at lib$rsvp$$internal$$tryCatch (/Users/flama/Projects/ember-cordova/node_modules/rsvp/dist/rsvp.js:1036:16)
    at lib$rsvp$$internal$$invokeCallback (/Users/flama/Projects/ember-cordova/node_modules/rsvp/dist/rsvp.js:1048:17)
    at /Users/flama/Projects/ember-cordova/node_modules/rsvp/dist/rsvp.js:331:11
    at lib$rsvp$asap$$flush (/Users/flama/Projects/ember-cordova/node_modules/rsvp/dist/rsvp.js:1198:9)
    at doNTCallback0 (node.js:407:9)
    at process._tickCallback (node.js:336:13)
Livereload server on http://localhost:49152
Serving on http://localhost:4200/
@villander villander changed the title I can't run the addo to contribuing I can't run the addon to contribuing Apr 16, 2016
@runspired
Copy link
Contributor

runspired commented Apr 18, 2016

There is no (ember-cordova) error in your trace above...

@villander
Copy link
Author

villander commented Apr 18, 2016

@runspired what the error, i can't run ember-cordova project ? Help me!

@runspired runspired changed the title I can't run the addon to contribuing Addon is missing a dummy app for testing Apr 18, 2016
@runspired
Copy link
Contributor

@villander misread this initially as you were having trouble in a consuming app, not trying to mess with the lib itself, sorry!

The error here is that there is no dummy app, which "sorta makes sense" (I don't actually think it does) because there isn't an Ember code to test here, really. It's mostly cordova integration code.

@alexblom guessing this goes into the "we need a better test story" column.

@runspired runspired reopened this Apr 18, 2016
@villander
Copy link
Author

@runspired thanks I knew it was something related to dummy app, i should have communicated better haha.

Anyway we need a dummy to test and ensure the quality ofaddon without having another project for this. What do you think @alexblom ?

@alexblom
Copy link
Member

alexblom commented May 3, 2016

I'd agree having a dummy app for the test story makes sense. In general, I think the test story is weak. I'm just coming off a crazy sprint and can now dedicate regular time here again.

Fixing testing is something I'm doing this week. Will keep this issue updated, if you have any time to help out lmk.

@alexblom alexblom self-assigned this Jun 5, 2016
@alexblom
Copy link
Member

alexblom commented Jun 5, 2016

Just to update, I'll be pushing a testing branch that resolves this.

@villander
Copy link
Author

Thanks @alexblom 💃

@villander
Copy link
Author

villander commented Jul 29, 2016

@alexblom i'm up-to-date with branch master of this repo. and still not have a dummy app

I can't run this project :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants