Remove unsafe & ManuallyDrop about shared data structrues #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
bitboom
requested review from
zpzigi754,
bokdeuk-jeong,
jinbpark and
hihi-wang
jinbpark
approved these changes
Aug 10, 2023
|
Does it have something to do with ACS tests? (it seems not I guess) |
jinbpark
reviewed
Aug 10, 2023
It is not related with ACS directly. I am currently debugging below issue. Current issueI found that RMM reads dummy values (0xCFDFDFDF) with ACS tests.
|
hihi-wang
reviewed
Aug 10, 2023
zpzigi754
approved these changes
Aug 10, 2023
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
unsafe & ManuallyDropUnsafe & ManuallyDropwas introduced by union type. (the way of tf-rmm implement)I change this by adding padding.
I will apply this way to other structures continuously