Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support RMI_RTT_UNMAP_UNPROTECTED #154

Merged
merged 1 commit into from
Aug 24, 2023
Merged

support RMI_RTT_UNMAP_UNPROTECTED #154

merged 1 commit into from
Aug 24, 2023

Conversation

jinbpark
Copy link
Collaborator

ACS status with this PR,

REGRESSION REPORT:
==================
   TOTAL TESTS     : 59
   TOTAL PASSED    : 6
   TOTAL FAILED    : 48
   TOTAL SKIPPED   : 2
   TOTAL SIM ERROR : 3

The following tests have newly passed with this PR.

cmd_rmi_version
cmd_rsi_version
cmd_realm_config
cmd_ipa_state_get

This result has been updated to #149 .

hihi-wang
hihi-wang reviewed Aug 23, 2023
View reviewed changes
rmm/monitor/src/rmi/rtt.rs Outdated
listen!(mainloop, rmi::RTT_UNMAP_UNPROTECTED, |arg, _ret, rmm| {
let rmi = rmm.rmi;
let ipa = arg[1];
let _level = arg[2];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to keep this variable...?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

@zpzigi754
Copy link
Collaborator

FYI, RMI_RTT_MAP_UNPROTECTED (together with RMI_RTT_READ_ENTRY, RMI_RTT_SET_RIPAS, RSI_REALM_CONFIG) has been re-implemented for addressing the memory sharing issue. I will soon upload it!

zpzigi754
zpzigi754 approved these changes Aug 24, 2023
View reviewed changes
rmm/monitor/src/rmi/rtt.rs Outdated

let rd_granule = get_granule_if!(arg[0], GranuleState::RD)?;
let rd = rd_granule.content::<Rd>();
let _ = rmi.unmap(rd.id(), ipa, GRANULE_SIZE);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing the last line into rmi.unmap(rd.id(), ipa, GRANULE_SIZE)?; for the error handling?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks!

@jinbpark
support RMI_RTT_UNMAP_UNPROTECTED
646b6a1 
Signed-off-by: Jinbum Park <jinb.park@samsung.com>
@jinbpark jinbpark merged commit a1e210c into main Aug 24, 2023
5 checks passed
@jinbpark jinbpark deleted the unmap_unprotected branch August 24, 2023 01:24
@bitboom bitboom mentioned this pull request Aug 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hihi-wang hihi-wang hihi-wang left review comments

@bitboom bitboom bitboom approved these changes

@zpzigi754 zpzigi754 zpzigi754 approved these changes

@bokdeuk-jeong bokdeuk-jeong Awaiting requested review from bokdeuk-jeong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jinbpark @zpzigi754 @bitboom @hihi-wang