Pass the remaining tests in rtt_init_ripas and rtt_create #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitboom
approved these changes
Oct 13, 2023
zpzigi754
requested review from
nook1208,
bokdeuk-jeong,
jinbpark and
hihi-wang
bokdeuk-jeong
approved these changes
Oct 13, 2023
This will pass the remaining tests in ACS's rtt_init_ripas.
This will pass the remaining tests in ACS's rtt_create.
zpzigi754
force-pushed
the
pass-rtt-tests
branch
2 times, most recently
from
7572a20
to
be40153
Compare
zpzigi754
force-pushed
the
pass-rtt-tests
branch
from
be40153
to
25ac358
Compare
nook1208
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing checks and cases in rtt_create and rtt_init_ripas. All the remaining tests regarding these APIs will be passed.
[before]
[after]
rtt_init_ripas now fail after rebasing. I will fix this issue in another PR.