Add validity checks in rtt_map_unprotected #220
Conversation
zpzigi754
force-pushed
the
fix-rtt-map-unprotected
branch
from
5ad7d8d
to
8867e79
Compare
zpzigi754
changed the title
zpzigi754
force-pushed
the
fix-rtt-map-unprotected
branch
from
8867e79
to
f38480c
Compare
scripts/fvp-cca
Outdated
| @@ -570,6 +570,9 @@ if __name__ == "__main__": | |||
| prepare_nw_aosp(args.no_prebuilt_initrd) | |||
| prepare_bootloaders(args.rmm, PREBUILT_EDK2, args.hes) | |||
| elif args.normal_world == "acs": | |||
| # Clear out build directory so that the current target is | |||
| # not confused by the previous target | |||
| run(["rm", "-rf", "build"], cwd=ACS) | |||
There was a problem hiding this comment.
[IMHO] I think it's enough to clean only when with --clean option or remove manually than removing every time.
There was a problem hiding this comment.
Good opinion! I also think that it might be enough to explicitly clean with ./scripts/fvp-cca --clean or manually deleting third-party/cca-rmm-acs/build.
Currently, ./scripts/fvp-cca --clean not only clean ACS, but also clean other third-party submodules (tf-a, kvmtool realm-linux, etc) altogether which I wanted to avoid (e.g., building realm-linux after clearing would take a lot of time). For the second option, it requires an internal knowledge about the ACS's build system which users might not be aware of.
In my personal experience, building acs from the initial state (after removing build dir) did not add much time (a few seconds) in the testing because the module size is relatively small. That's the reason why I chose building ACS from the initial state every time.
There was a problem hiding this comment.
I will make scripts/fvp-cca --clean into scripts/fvp-cca --clean <target> (e.g., scripts/fvp-cca --clean acs) and do not remove build directory every time after leaving some comment that acs should be cleaned if selected-tests or excluded-tests are used!
This will pass the whole tests in ACS's rtt_map_unprotected.
zpzigi754
force-pushed
the
fix-rtt-map-unprotected
branch
from
f38480c
to
26c39c2
Compare
[before]
./scripts/fvp-cca --clean
[after]
./scripts/fvp-cca --clean <target>
e.g., ./scripts/fvp-cca --clean all
./scripts/fvp-cca --clean acs
zpzigi754
force-pushed
the
fix-rtt-map-unprotected
branch
from
26c39c2
to
6e61184
Compare
This PR adds missing checks in rtt_map_unprotected. All the tests in ACS's rtt_map_unprotected will be passed after this change.
[before]
[after]