Add config for aria labels and text labels, and fix test #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thormeier
commented
Apr 18, 2023
| @@ -25,6 +25,6 @@ describe('getCurrentSlideIndex', () => { | |||
| const max = 10 | |||
| const results = mapNumberToRange({ val, min, max }) | |||
|
|
|||
| expect(results).toBe(5) | |||
| expect(results).toBe(7) | |||
thormeier
commented
Apr 18, 2023
src/components/Pagination.ts
Outdated
| @@ -25,7 +27,7 @@ const Pagination = () => { | |||
| 'carousel__pagination-button': true, | |||
| 'carousel__pagination-button--active': isActive(slide), | |||
| }, | |||
| 'aria-label': `Navigate to slide ${slide + 1}`, | |||
| 'aria-label': config.labels?.ariaNavigateToSlide + ' ' + (slide + 1).toString(), | |||
There was a problem hiding this comment.
I used some kind of template to allow for simpler translations of Item X of Y, we perhaps want something similar here, too.
There was a problem hiding this comment.
Yes, It's better to have a unified API
thormeier
commented
Apr 18, 2023
src/components/Icon.ts
Outdated
| const iconTitle = (props.title | ||
| || (config.labels?.iconAriaLabels ? config!.labels!.iconAriaLabels![iconName]! as string : undefined) | ||
| || iconName | ||
| ) as string |
There was a problem hiding this comment.
Still uses the icon name as a fallback but prefers the configured title. Not sure if that's alright the way it is or if we should inject the translated aria label via props instead.
|
@thormeier Thank you for your awesome work. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302 and implements #278.
I tried to stick to the code style as much as possible. I had to type the icons more explicitly for them to be translateable, but in turn, I also added translations for the icons. I added an example to the docs and added the new object to the config table. We might want to think of a better way to show the new config object since I couldn't indent it in the markdown table nicely.
Thank you very much for this library!