Fix/phase 0 #43
Merged
Fix/phase 0 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnaciodeNuevo
added a commit
that referenced
this pull request
Jul 10, 2018
* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (microsoft#1552) * cleaned up exception handling in loading image (microsoft#1526) * Enable member init checks and fix errors (microsoft#1566) * A class with only static methods and no state should just be a namespace. (microsoft#1567) * Support OnParseAction Handler (microsoft#1570) * Honour preexpandSingleShowCardAction and weight of fact title from HostConfig * Addressed comments * Support OnParseAction * resolved minor comments * Jwoo/ios render sync (microsoft#1547) * make rendering to be syncronoush by default * updated custom textblock renderer * changes before CR * CR update * CR update * [.NET] Prevent async exceptions from tearing down the process (microsoft#1561) * Prevent unobserved exceptions from taking down the process. If rendering fails, report the error but do not throw on a background thread. * Add configuration to sign nuget packages * fixed dll/project names in comments * Fix actions parent not being set before actions are parsed (microsoft#1573) * Replace ContainerStyle string enum with class + static fields * Update default card * Improve hover behavior for Image with selectAction * Finalize support for width/height in Image and Column * Add support for icons on action buttons * Cleanup * Fix handling of buttons without title * Fix broken preExpandSingleShowCardAction handling * Fix actions parent not being set before actions are parsed * Enable const cppcore checks and fix fallout (microsoft#1575) * Add Events for media play and end (microsoft#1546) * [Android] Add vertical stretch property (microsoft#1525) * Add vertical stretch to android * Remove non related test file * Fix comments in FactSetRendered * Add tests as linked tests * Update tests results from TestApp with new tests * Jwoo/ios makrdown optimized (microsoft#1554) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * fixed build compatability issues below iOS 11.3 * fixes before CR * CR comments fix * Added additional headers to public lis in framework. (microsoft#1562) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * made headers public for customizing buttons * added ACRUILable.h * reverted wrong merge * Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (microsoft#1579) * Enable Declaration warnings and first round of fixes * Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp * added ability to scroll when there are more buttons than viewing area (microsoft#1581) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * fixed build compatability issues below iOS 11.3 * fixes before CR * added UIScrollView to ActionSet * edits before CR * Added sample json and updates b4 CR * Enable "rule of five" checker, fix errors (microsoft#1585) * Add Teams containers (microsoft#1469) Add support for more properties in property sheet Add initial support for snippets * [iOS] Add vertical stretch support (microsoft#1584) * Add vertical stretch to android * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * Remove non related test file * Fix comments in FactSetRendered * Add tests as linked tests * Update tests results from TestApp with new tests * Add vertical stretch for items * Remove 'changes' from merge * Add vertical stretch tests to solution * Fix issue for image in columnsets rendering * Fix issue for images being shorter than other columns in columnset * Keep alignment leading for cards with no stretchable items * Add new test for auto size image * Enable all cppcorecheck class warnings and fix errors (microsoft#1601) * Enable override checker and fix errors * Enable function hiding warning and fix errors * Enable all class warnings and fix errors * [iOS] Add missing test for Vertical Stretch (microsoft#1603) * Add missing test * Fix spaces in json * Update GetResource method to include type and to support media (microsoft#1583) * Update get resource method to include type and to support media * Handle opening media via resource resolver when play is pressed (microsoft#1586) Handle opening media via resource resolver when play is pressed * Enable unit test code coverage in Debug Win32 builds (microsoft#1611) * Test source file updates (microsoft#1551) * Test file updates * Jwoo/ios custom styling (microsoft#1474) * XIB first commit * fixes merge error * updated InputView with XIB updated the style of UIButtons added UITableViewCell xib for compact mode removed comments * code clean up * added ACRbutton.xib * Added Xib for CompactCell * added ACRButton.xib * allowed column with numeric width value to stretch (microsoft#1595) * allowed column with numeric width value to stretch * fix merge and remove spacing for the first item * [UWP][Android][iOS] Add aesthetic fix Icons in Actions (microsoft#1612) * Add aesthetic fix to UWP * Aesthetic fix for android * Aesthetic fix for iOS * Add json test files to project * Fix formatting * updated showcard rendering position (microsoft#1600) removed comments * compact style choice set "make choice" row will reflect user choice (microsoft#1596) * in progress * when user chooses, user choice will be shown * updated default message * value is used instead of "Make Choice" * handles cases where compact style lacking defaults (microsoft#1627) * fixed separator issue (microsoft#1629) * Remove Stretch from vertical content alignment (microsoft#1630) * Jwoo/explicit image size ios (microsoft#1374) * explicit image changes * Added 'Explicit' enum value * uwp changes * uwp changes * added explicit image sizing option for ios * removed division * fixes extra spacing issue in UICollectionView (microsoft#1628) * fixes extra spacing issue in UICollectionView * refined intrinsic content size for collection view * fixed precision error * fixes url loading sync issue for actions (microsoft#1641) * fixes url loading sync issue for actions removed hard coded image icon placement * fixed indentation and changed variable name * Fix media controls (microsoft#1614) * [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (microsoft#1636) * Input.Text roundtrip, added test and fix * feedback -vertical spaces * Change private for protected in all Renderers constructors (microsoft#1649) * Add vertical scroll support (microsoft#1650) * Jwoo/ios custom background image loader (microsoft#1642) * fixes url loading sync issue for actions removed hard coded image icon placement * allows custom BG IMG renderer * Added CustomImageRenderer to sample * removed CoreGraphics framework as it's not used * added a test to ensure Unicode/Emoji support (microsoft#1647) :shipit: * multiline input and input limit for textview and textfield (microsoft#1643) * initial commit for multiline input and input limit implmt plc hld txt; rmved max len chg when not set reverted json files * Refactoring and code clean-up * updated whitespaces * Fixed newline char * [Android] Refocus when a show card changes visibility (microsoft#1651) * Refocus on show card * Set focus for cards instead of input fields * Revert "[Android] Refocus when a show card changes visibility (microsoft#1651)" (microsoft#1653) This reverts commit f2a899a. * 52619-to-much-padding-in-tree-view * 52614-tree-view-is-very-messy-as-it-is-resized-to-limited-width * Reverted to Fabric UI instead of SVGs (#33) * Reverted to Fabric UI instead of SVGs * Removed unnecesary comments * Removed unnecesary CSS and duplicated one (#35) * Fix/use hostconfig to add container styles (#36) * background fix * Added background color via CSS again * Fixed some colours * Fixed class names in CSS and HTML * Moved interfaz to separate component * Fixed action and add column styles * Reverted removed commented code * Removed CSS properties panel color modification * Changed querySelector by getElementById * Removed commented code * Fix/hostconfig styles (#37) * Changed SVGs to FabriUI Font * Changed SVGs to FabriUI Font * Changed aside-panel icons when folded * Added cursor pointer to panel headers and avoided user-select it's text * Added cursor pointer to properties/treewview panels when folded * Added treeview icon fonts from FabricUI instead of SVGs * Fixed treeview icons positon * Fix/treeview implementation (#38) * Half of treeview refactor * Finished treeview * Removed unnecesary btn class and fixed treeview icons position * Removed unnecesary treeview component * Removed outline as David Claux did to match he's style * Mantained folded state when needed * Removed unnecesary console.log * Removed unnecesary icons (#39) * Fix/minor microsoft pr changes (#40) * Removed unnecesary icons * Removed blank line * Fix/phase 0 (#41) * Changed aside panel background's color * Maded JSON togglable * Refactored CSS * Fixed PR comments * Fix/phase 0 (#43) * Changed aside panel background's color * Maded JSON togglable * Refactored CSS * Fixed PR comments * Removed unnecesary code
Merged
IgnaciodeNuevo
added a commit
that referenced
this pull request
Jul 10, 2018
* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (microsoft#1552) * cleaned up exception handling in loading image (microsoft#1526) * Enable member init checks and fix errors (microsoft#1566) * A class with only static methods and no state should just be a namespace. (microsoft#1567) * Support OnParseAction Handler (microsoft#1570) * Honour preexpandSingleShowCardAction and weight of fact title from HostConfig * Addressed comments * Support OnParseAction * resolved minor comments * Jwoo/ios render sync (microsoft#1547) * make rendering to be syncronoush by default * updated custom textblock renderer * changes before CR * CR update * CR update * [.NET] Prevent async exceptions from tearing down the process (microsoft#1561) * Prevent unobserved exceptions from taking down the process. If rendering fails, report the error but do not throw on a background thread. * Add configuration to sign nuget packages * fixed dll/project names in comments * Fix actions parent not being set before actions are parsed (microsoft#1573) * Replace ContainerStyle string enum with class + static fields * Update default card * Improve hover behavior for Image with selectAction * Finalize support for width/height in Image and Column * Add support for icons on action buttons * Cleanup * Fix handling of buttons without title * Fix broken preExpandSingleShowCardAction handling * Fix actions parent not being set before actions are parsed * Enable const cppcore checks and fix fallout (microsoft#1575) * Add Events for media play and end (microsoft#1546) * [Android] Add vertical stretch property (microsoft#1525) * Add vertical stretch to android * Remove non related test file * Fix comments in FactSetRendered * Add tests as linked tests * Update tests results from TestApp with new tests * Jwoo/ios makrdown optimized (microsoft#1554) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * fixed build compatability issues below iOS 11.3 * fixes before CR * CR comments fix * Added additional headers to public lis in framework. (microsoft#1562) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * made headers public for customizing buttons * added ACRUILable.h * reverted wrong merge * Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (microsoft#1579) * Enable Declaration warnings and first round of fixes * Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp * added ability to scroll when there are more buttons than viewing area (microsoft#1581) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * fixed build compatability issues below iOS 11.3 * fixes before CR * added UIScrollView to ActionSet * edits before CR * Added sample json and updates b4 CR * Enable "rule of five" checker, fix errors (microsoft#1585) * Add Teams containers (microsoft#1469) Add support for more properties in property sheet Add initial support for snippets * [iOS] Add vertical stretch support (microsoft#1584) * Add vertical stretch to android * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * Remove non related test file * Fix comments in FactSetRendered * Add tests as linked tests * Update tests results from TestApp with new tests * Add vertical stretch for items * Remove 'changes' from merge * Add vertical stretch tests to solution * Fix issue for image in columnsets rendering * Fix issue for images being shorter than other columns in columnset * Keep alignment leading for cards with no stretchable items * Add new test for auto size image * Enable all cppcorecheck class warnings and fix errors (microsoft#1601) * Enable override checker and fix errors * Enable function hiding warning and fix errors * Enable all class warnings and fix errors * [iOS] Add missing test for Vertical Stretch (microsoft#1603) * Add missing test * Fix spaces in json * Update GetResource method to include type and to support media (microsoft#1583) * Update get resource method to include type and to support media * Handle opening media via resource resolver when play is pressed (microsoft#1586) Handle opening media via resource resolver when play is pressed * Enable unit test code coverage in Debug Win32 builds (microsoft#1611) * Test source file updates (microsoft#1551) * Test file updates * Jwoo/ios custom styling (microsoft#1474) * XIB first commit * fixes merge error * updated InputView with XIB updated the style of UIButtons added UITableViewCell xib for compact mode removed comments * code clean up * added ACRbutton.xib * Added Xib for CompactCell * added ACRButton.xib * allowed column with numeric width value to stretch (microsoft#1595) * allowed column with numeric width value to stretch * fix merge and remove spacing for the first item * [UWP][Android][iOS] Add aesthetic fix Icons in Actions (microsoft#1612) * Add aesthetic fix to UWP * Aesthetic fix for android * Aesthetic fix for iOS * Add json test files to project * Fix formatting * updated showcard rendering position (microsoft#1600) removed comments * compact style choice set "make choice" row will reflect user choice (microsoft#1596) * in progress * when user chooses, user choice will be shown * updated default message * value is used instead of "Make Choice" * handles cases where compact style lacking defaults (microsoft#1627) * fixed separator issue (microsoft#1629) * Remove Stretch from vertical content alignment (microsoft#1630) * Jwoo/explicit image size ios (microsoft#1374) * explicit image changes * Added 'Explicit' enum value * uwp changes * uwp changes * added explicit image sizing option for ios * removed division * fixes extra spacing issue in UICollectionView (microsoft#1628) * fixes extra spacing issue in UICollectionView * refined intrinsic content size for collection view * fixed precision error * fixes url loading sync issue for actions (microsoft#1641) * fixes url loading sync issue for actions removed hard coded image icon placement * fixed indentation and changed variable name * Fix media controls (microsoft#1614) * [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (microsoft#1636) * Input.Text roundtrip, added test and fix * feedback -vertical spaces * Change private for protected in all Renderers constructors (microsoft#1649) * Add vertical scroll support (microsoft#1650) * Jwoo/ios custom background image loader (microsoft#1642) * fixes url loading sync issue for actions removed hard coded image icon placement * allows custom BG IMG renderer * Added CustomImageRenderer to sample * removed CoreGraphics framework as it's not used * added a test to ensure Unicode/Emoji support (microsoft#1647) :shipit: * multiline input and input limit for textview and textfield (microsoft#1643) * initial commit for multiline input and input limit implmt plc hld txt; rmved max len chg when not set reverted json files * Refactoring and code clean-up * updated whitespaces * Fixed newline char * [Android] Refocus when a show card changes visibility (microsoft#1651) * Refocus on show card * Set focus for cards instead of input fields * Revert "[Android] Refocus when a show card changes visibility (microsoft#1651)" (microsoft#1653) This reverts commit f2a899a. * 52619-to-much-padding-in-tree-view * 52614-tree-view-is-very-messy-as-it-is-resized-to-limited-width * Reverted to Fabric UI instead of SVGs (#33) * Reverted to Fabric UI instead of SVGs * Removed unnecesary comments * Removed unnecesary CSS and duplicated one (#35) * Fix/use hostconfig to add container styles (#36) * background fix * Added background color via CSS again * Fixed some colours * Fixed class names in CSS and HTML * Moved interfaz to separate component * Fixed action and add column styles * Reverted removed commented code * Removed CSS properties panel color modification * Changed querySelector by getElementById * Removed commented code * Fix/hostconfig styles (#37) * Changed SVGs to FabriUI Font * Changed SVGs to FabriUI Font * Changed aside-panel icons when folded * Added cursor pointer to panel headers and avoided user-select it's text * Added cursor pointer to properties/treewview panels when folded * Added treeview icon fonts from FabricUI instead of SVGs * Fixed treeview icons positon * Fix/treeview implementation (#38) * Half of treeview refactor * Finished treeview * Removed unnecesary btn class and fixed treeview icons position * Removed unnecesary treeview component * Removed outline as David Claux did to match he's style * Mantained folded state when needed * Removed unnecesary console.log * Removed unnecesary icons (#39) * Fix/minor microsoft pr changes (#40) * Removed unnecesary icons * Removed blank line * Fix/phase 0 (#41) * Changed aside panel background's color * Maded JSON togglable * Refactored CSS * Fixed PR comments * Fix/phase 0 (#43) * Changed aside panel background's color * Maded JSON togglable * Refactored CSS * Fixed PR comments * Removed unnecesary code
IgnaciodeNuevo
added a commit
that referenced
this pull request
Jul 13, 2018
* Fix/phase 0 (#43) * Changed aside panel background's color * Maded JSON togglable * Refactored CSS * Fixed PR comments * Removed unnecesary code * Fix/json overflow (#46) * Fixed JSON title width * Moved to HTML monaco-editor's nav-title * Fixed toggle class implementation when updatingLayout in the treeview * Fixed aside scrollbar * Fixed properties panel label's width * Fixed JSON panel height when toggled * Fixed properties panel paddings and FactSet padding-right and padding-left * Fixed treeview background-color
IgnaciodeNuevo
added a commit
that referenced
this pull request
Jul 13, 2018
* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (microsoft#1552) * cleaned up exception handling in loading image (microsoft#1526) * Enable member init checks and fix errors (microsoft#1566) * A class with only static methods and no state should just be a namespace. (microsoft#1567) * Support OnParseAction Handler (microsoft#1570) * Honour preexpandSingleShowCardAction and weight of fact title from HostConfig * Addressed comments * Support OnParseAction * resolved minor comments * Jwoo/ios render sync (microsoft#1547) * make rendering to be syncronoush by default * updated custom textblock renderer * changes before CR * CR update * CR update * [.NET] Prevent async exceptions from tearing down the process (microsoft#1561) * Prevent unobserved exceptions from taking down the process. If rendering fails, report the error but do not throw on a background thread. * Add configuration to sign nuget packages * fixed dll/project names in comments * Fix actions parent not being set before actions are parsed (microsoft#1573) * Replace ContainerStyle string enum with class + static fields * Update default card * Improve hover behavior for Image with selectAction * Finalize support for width/height in Image and Column * Add support for icons on action buttons * Cleanup * Fix handling of buttons without title * Fix broken preExpandSingleShowCardAction handling * Fix actions parent not being set before actions are parsed * Enable const cppcore checks and fix fallout (microsoft#1575) * Add Events for media play and end (microsoft#1546) * [Android] Add vertical stretch property (microsoft#1525) * Add vertical stretch to android * Remove non related test file * Fix comments in FactSetRendered * Add tests as linked tests * Update tests results from TestApp with new tests * Jwoo/ios makrdown optimized (microsoft#1554) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * fixed build compatability issues below iOS 11.3 * fixes before CR * CR comments fix * Added additional headers to public lis in framework. (microsoft#1562) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * made headers public for customizing buttons * added ACRUILable.h * reverted wrong merge * Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (microsoft#1579) * Enable Declaration warnings and first round of fixes * Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp * added ability to scroll when there are more buttons than viewing area (microsoft#1581) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * fixed build compatability issues below iOS 11.3 * fixes before CR * added UIScrollView to ActionSet * edits before CR * Added sample json and updates b4 CR * Enable "rule of five" checker, fix errors (microsoft#1585) * Add Teams containers (microsoft#1469) Add support for more properties in property sheet Add initial support for snippets * [iOS] Add vertical stretch support (microsoft#1584) * Add vertical stretch to android * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * Remove non related test file * Fix comments in FactSetRendered * Add tests as linked tests * Update tests results from TestApp with new tests * Add vertical stretch for items * Remove 'changes' from merge * Add vertical stretch tests to solution * Fix issue for image in columnsets rendering * Fix issue for images being shorter than other columns in columnset * Keep alignment leading for cards with no stretchable items * Add new test for auto size image * Enable all cppcorecheck class warnings and fix errors (microsoft#1601) * Enable override checker and fix errors * Enable function hiding warning and fix errors * Enable all class warnings and fix errors * [iOS] Add missing test for Vertical Stretch (microsoft#1603) * Add missing test * Fix spaces in json * Update GetResource method to include type and to support media (microsoft#1583) * Update get resource method to include type and to support media * Handle opening media via resource resolver when play is pressed (microsoft#1586) Handle opening media via resource resolver when play is pressed * Enable unit test code coverage in Debug Win32 builds (microsoft#1611) * Test source file updates (microsoft#1551) * Test file updates * Jwoo/ios custom styling (microsoft#1474) * XIB first commit * fixes merge error * updated InputView with XIB updated the style of UIButtons added UITableViewCell xib for compact mode removed comments * code clean up * added ACRbutton.xib * Added Xib for CompactCell * added ACRButton.xib * allowed column with numeric width value to stretch (microsoft#1595) * allowed column with numeric width value to stretch * fix merge and remove spacing for the first item * [UWP][Android][iOS] Add aesthetic fix Icons in Actions (microsoft#1612) * Add aesthetic fix to UWP * Aesthetic fix for android * Aesthetic fix for iOS * Add json test files to project * Fix formatting * updated showcard rendering position (microsoft#1600) removed comments * compact style choice set "make choice" row will reflect user choice (microsoft#1596) * in progress * when user chooses, user choice will be shown * updated default message * value is used instead of "Make Choice" * handles cases where compact style lacking defaults (microsoft#1627) * fixed separator issue (microsoft#1629) * Remove Stretch from vertical content alignment (microsoft#1630) * Jwoo/explicit image size ios (microsoft#1374) * explicit image changes * Added 'Explicit' enum value * uwp changes * uwp changes * added explicit image sizing option for ios * removed division * fixes extra spacing issue in UICollectionView (microsoft#1628) * fixes extra spacing issue in UICollectionView * refined intrinsic content size for collection view * fixed precision error * fixes url loading sync issue for actions (microsoft#1641) * fixes url loading sync issue for actions removed hard coded image icon placement * fixed indentation and changed variable name * Fix media controls (microsoft#1614) * [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (microsoft#1636) * Input.Text roundtrip, added test and fix * feedback -vertical spaces * Change private for protected in all Renderers constructors (microsoft#1649) * Add vertical scroll support (microsoft#1650) * Jwoo/ios custom background image loader (microsoft#1642) * fixes url loading sync issue for actions removed hard coded image icon placement * allows custom BG IMG renderer * Added CustomImageRenderer to sample * removed CoreGraphics framework as it's not used * added a test to ensure Unicode/Emoji support (microsoft#1647) :shipit: * multiline input and input limit for textview and textfield (microsoft#1643) * initial commit for multiline input and input limit implmt plc hld txt; rmved max len chg when not set reverted json files * Refactoring and code clean-up * updated whitespaces * Fixed newline char * [Android] Refocus when a show card changes visibility (microsoft#1651) * Refocus on show card * Set focus for cards instead of input fields * Revert "[Android] Refocus when a show card changes visibility (microsoft#1651)" (microsoft#1653) This reverts commit f2a899a. * 52619-to-much-padding-in-tree-view * 52614-tree-view-is-very-messy-as-it-is-resized-to-limited-width * Reverted to Fabric UI instead of SVGs (#33) * Reverted to Fabric UI instead of SVGs * Removed unnecesary comments * Removed unnecesary CSS and duplicated one (#35) * Fix/use hostconfig to add container styles (#36) * background fix * Added background color via CSS again * Fixed some colours * Fixed class names in CSS and HTML * Moved interfaz to separate component * Fixed action and add column styles * Reverted removed commented code * Removed CSS properties panel color modification * Changed querySelector by getElementById * Removed commented code * Fix/hostconfig styles (#37) * Changed SVGs to FabriUI Font * Changed SVGs to FabriUI Font * Changed aside-panel icons when folded * Added cursor pointer to panel headers and avoided user-select it's text * Added cursor pointer to properties/treewview panels when folded * Added treeview icon fonts from FabricUI instead of SVGs * Fixed treeview icons positon * Fix/treeview implementation (#38) * Half of treeview refactor * Finished treeview * Removed unnecesary btn class and fixed treeview icons position * Removed unnecesary treeview component * Removed outline as David Claux did to match he's style * Mantained folded state when needed * Removed unnecesary console.log * Removed unnecesary icons (#39) * Fix/minor microsoft pr changes (#40) * Removed unnecesary icons * Removed blank line * Fix/phase 0 (#41) * Changed aside panel background's color * Maded JSON togglable * Refactored CSS * Fixed PR comments * Fix/phase 0 (#43) * Changed aside panel background's color * Maded JSON togglable * Refactored CSS * Fixed PR comments * Removed unnecesary code * Fix/json overflow (#46) * Fixed JSON title width * Moved to HTML monaco-editor's nav-title * Fixed toggle class implementation when updatingLayout in the treeview * Fixed aside scrollbar * Fixed properties panel label's width * Fixed JSON panel height when toggled * Fixed properties panel paddings and FactSet padding-right and padding-left * Fixed treeview background-color
ismanapa
pushed a commit
that referenced
this pull request
Jul 18, 2018
* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (microsoft#1552) * cleaned up exception handling in loading image (microsoft#1526) * Enable member init checks and fix errors (microsoft#1566) * A class with only static methods and no state should just be a namespace. (microsoft#1567) * Support OnParseAction Handler (microsoft#1570) * Honour preexpandSingleShowCardAction and weight of fact title from HostConfig * Addressed comments * Support OnParseAction * resolved minor comments * Jwoo/ios render sync (microsoft#1547) * make rendering to be syncronoush by default * updated custom textblock renderer * changes before CR * CR update * CR update * [.NET] Prevent async exceptions from tearing down the process (microsoft#1561) * Prevent unobserved exceptions from taking down the process. If rendering fails, report the error but do not throw on a background thread. * Add configuration to sign nuget packages * fixed dll/project names in comments * Fix actions parent not being set before actions are parsed (microsoft#1573) * Replace ContainerStyle string enum with class + static fields * Update default card * Improve hover behavior for Image with selectAction * Finalize support for width/height in Image and Column * Add support for icons on action buttons * Cleanup * Fix handling of buttons without title * Fix broken preExpandSingleShowCardAction handling * Fix actions parent not being set before actions are parsed * Enable const cppcore checks and fix fallout (microsoft#1575) * Add Events for media play and end (microsoft#1546) * [Android] Add vertical stretch property (microsoft#1525) * Add vertical stretch to android * Remove non related test file * Fix comments in FactSetRendered * Add tests as linked tests * Update tests results from TestApp with new tests * Jwoo/ios makrdown optimized (microsoft#1554) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * fixed build compatability issues below iOS 11.3 * fixes before CR * CR comments fix * Added additional headers to public lis in framework. (microsoft#1562) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * made headers public for customizing buttons * added ACRUILable.h * reverted wrong merge * Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (microsoft#1579) * Enable Declaration warnings and first round of fixes * Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp * added ability to scroll when there are more buttons than viewing area (microsoft#1581) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * fixed build compatability issues below iOS 11.3 * fixes before CR * added UIScrollView to ActionSet * edits before CR * Added sample json and updates b4 CR * Enable "rule of five" checker, fix errors (microsoft#1585) * Add Teams containers (microsoft#1469) Add support for more properties in property sheet Add initial support for snippets * [iOS] Add vertical stretch support (microsoft#1584) * Add vertical stretch to android * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * Remove non related test file * Fix comments in FactSetRendered * Add tests as linked tests * Update tests results from TestApp with new tests * Add vertical stretch for items * Remove 'changes' from merge * Add vertical stretch tests to solution * Fix issue for image in columnsets rendering * Fix issue for images being shorter than other columns in columnset * Keep alignment leading for cards with no stretchable items * Add new test for auto size image * Enable all cppcorecheck class warnings and fix errors (microsoft#1601) * Enable override checker and fix errors * Enable function hiding warning and fix errors * Enable all class warnings and fix errors * [iOS] Add missing test for Vertical Stretch (microsoft#1603) * Add missing test * Fix spaces in json * Update GetResource method to include type and to support media (microsoft#1583) * Update get resource method to include type and to support media * Handle opening media via resource resolver when play is pressed (microsoft#1586) Handle opening media via resource resolver when play is pressed * Enable unit test code coverage in Debug Win32 builds (microsoft#1611) * Test source file updates (microsoft#1551) * Test file updates * Jwoo/ios custom styling (microsoft#1474) * XIB first commit * fixes merge error * updated InputView with XIB updated the style of UIButtons added UITableViewCell xib for compact mode removed comments * code clean up * added ACRbutton.xib * Added Xib for CompactCell * added ACRButton.xib * allowed column with numeric width value to stretch (microsoft#1595) * allowed column with numeric width value to stretch * fix merge and remove spacing for the first item * [UWP][Android][iOS] Add aesthetic fix Icons in Actions (microsoft#1612) * Add aesthetic fix to UWP * Aesthetic fix for android * Aesthetic fix for iOS * Add json test files to project * Fix formatting * updated showcard rendering position (microsoft#1600) removed comments * compact style choice set "make choice" row will reflect user choice (microsoft#1596) * in progress * when user chooses, user choice will be shown * updated default message * value is used instead of "Make Choice" * handles cases where compact style lacking defaults (microsoft#1627) * fixed separator issue (microsoft#1629) * Remove Stretch from vertical content alignment (microsoft#1630) * Jwoo/explicit image size ios (microsoft#1374) * explicit image changes * Added 'Explicit' enum value * uwp changes * uwp changes * added explicit image sizing option for ios * removed division * fixes extra spacing issue in UICollectionView (microsoft#1628) * fixes extra spacing issue in UICollectionView * refined intrinsic content size for collection view * fixed precision error * fixes url loading sync issue for actions (microsoft#1641) * fixes url loading sync issue for actions removed hard coded image icon placement * fixed indentation and changed variable name * Fix media controls (microsoft#1614) * [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (microsoft#1636) * Input.Text roundtrip, added test and fix * feedback -vertical spaces * Change private for protected in all Renderers constructors (microsoft#1649) * Add vertical scroll support (microsoft#1650) * Jwoo/ios custom background image loader (microsoft#1642) * fixes url loading sync issue for actions removed hard coded image icon placement * allows custom BG IMG renderer * Added CustomImageRenderer to sample * removed CoreGraphics framework as it's not used * added a test to ensure Unicode/Emoji support (microsoft#1647) :shipit: * multiline input and input limit for textview and textfield (microsoft#1643) * initial commit for multiline input and input limit implmt plc hld txt; rmved max len chg when not set reverted json files * Refactoring and code clean-up * updated whitespaces * Fixed newline char * [Android] Refocus when a show card changes visibility (microsoft#1651) * Refocus on show card * Set focus for cards instead of input fields * Revert "[Android] Refocus when a show card changes visibility (microsoft#1651)" (microsoft#1653) This reverts commit f2a899a. * changed toggle view to UISwitch (microsoft#1631) * changed toggle view to UISwitch * dev complete * streamlined selection process * updated project file & code clean-up * added sanity check;chd borderstyle;corner radius * [Android] Refocus when a show card changes visibility (microsoft#1654) * Refocus on show card * Set focus for cards instead of input fields * Fix activity retrieval * Fix formatting and null check * [Android] Add custom renderer for actions and actionlayouts (microsoft#1655) * Add functions to register action renderer * Add IActionLayoutRenderer to support full actionLayout modification * Fix PR commentsa * 52619-to-much-padding-in-tree-view * 52614-tree-view-is-very-messy-as-it-is-resized-to-limited-width * [Android] Custom image downloading fix (microsoft#1666) * Add overrideable method loadOnlineImage to allow image loading modification * Fix merge errors * Fix styling for images * bitCode added (microsoft#1674) * priority update for factset title (microsoft#1670) * added explicit column width for ios (microsoft#1672) * Reverted to Fabric UI instead of SVGs (#33) * Reverted to Fabric UI instead of SVGs * Removed unnecesary comments * Removed unnecesary CSS and duplicated one (#35) * Fix bug in XceedNumberInput.Render (microsoft#1679) XceedNumberInput.Render was setting numberPicker.Minimum to input.Max. This fixes it to set numberPicker.Maximum instead. * Add a GitHub issue template (microsoft#1678) * Add a GitHub issue template * Add some more questions to issue template * Updates to CONTRIBUTING.md - Don't tell people to use the Schema label since non-contributors can't use labels - Eliminate some early preview wording - Fix some links * Direct questions to StackOverflow * Fix/use hostconfig to add container styles (#36) * background fix * Added background color via CSS again * Fixed some colours * Fixed class names in CSS and HTML * Moved interfaz to separate component * Fixed action and add column styles * Reverted removed commented code * Removed CSS properties panel color modification * Changed querySelector by getElementById * Removed commented code * [Android] Fix for vertical scroll in input text (microsoft#1689) * Add touchlistener for vertical scroll in input text * Fix styling * Jwoo/variablenumoflines choiceset (microsoft#1687) * updated content sz calcuation logic for inputview * Updated Toggle Switch Style * inputView refinements * added ACRDateTextField * disable custom background image loading * fixes line clipping issue of toggle switch * costmetic changes before CR * CR changes * Fix/hostconfig styles (#37) * Changed SVGs to FabriUI Font * Changed SVGs to FabriUI Font * Changed aside-panel icons when folded * Added cursor pointer to panel headers and avoided user-select it's text * Added cursor pointer to properties/treewview panels when folded * Added treeview icon fonts from FabricUI instead of SVGs * Fixed treeview icons positon * Fix/treeview implementation (#38) * Half of treeview refactor * Finished treeview * Removed unnecesary btn class and fixed treeview icons position * Removed unnecesary treeview component * Removed outline as David Claux did to match he's style * Mantained folded state when needed * Removed unnecesary console.log * Removed unnecesary icons (#39) * Increase the information in the version error message (microsoft#1697) Increase the information in the error message when version fails to parse, and mark version as required in order to get a more specific error message * Fix/minor microsoft pr changes (#40) * Removed unnecesary icons * Removed blank line * Fix/phase 0 (#41) * Changed aside panel background's color * Maded JSON togglable * Refactored CSS * Fixed PR comments * Reverse backwards if to allow image tracking (microsoft#1700) * Fix/phase 0 (#43) * Changed aside panel background's color * Maded JSON togglable * Refactored CSS * Fixed PR comments * Removed unnecesary code * Fix/json overflow (#46) * Fixed JSON title width * Moved to HTML monaco-editor's nav-title * Fixed toggle class implementation when updatingLayout in the treeview * Fixed aside scrollbar * Fixed properties panel label's width * Fixed JSON panel height when toggled * Fixed properties panel paddings and FactSet padding-right and padding-left * Fixed treeview background-color * [CPP] Fix/cpp small fixes (microsoft#1681) * this was breaking the build on case-sensitive FS * lesser evil (no autosave); better to ignore the file, methinks * removed unused * reordered * Revert "removed unused" since ES.84 This reverts commit c403517. * reordered * Set AutomationProperties.Name to AltText on Images (microsoft#1701) * added resource resolver (microsoft#1702) * added resource resolver * Added resource resolver class * Added interface file * chged NSString to NSURL as arg to the resolver IF * Media event changes (microsoft#1712) * Fixes UI Issues (microsoft#1709) * Minor UI fixes * chececk pointer against boolVal message * removed extra method call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.