Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read more adds a single space that breaks the text #20

Closed
yabood opened this issue May 5, 2016 · 5 comments
Closed

Read more adds a single space that breaks the text #20

yabood opened this issue May 5, 2016 · 5 comments

Comments

@yabood
Copy link

yabood commented May 5, 2016

If the limit falls on a non-empty space, cutting off a word in the middle, the 'show more' will add a single space to the word after its clicked. In the demo you have here change the limit to 198 instead of 200. The '...' will appear on the last two letters of the word "mauris". Once you click show more, the word will be displayed like this "mauri s".
@goclixy-core
Copy link

goclixy-core commented May 24, 2016 •
edited

Edit directive and delete \n between
span ng-bind-html="vm.lessText" style="white-space:pre-wrap;" /span

\n

span ng-show="vm.showMoreText" class="more-show-hide" ng-bind-html="vm.moreText" style="white-space:pre-wrap;" /span

@ismarslomic
Copy link
Owner

Can you please make an pull request?

@bgsavage
Copy link

bgsavage commented Jun 7, 2016

Any updates on this? I'm seeing the same issue...

bgsavage pushed a commit to bgsavage/angular-read-more that referenced this issue Jun 8, 2016
Fixed issue ismarslomic#20: Removed \n from readmore.template.html wh…
03dfa28 
…ich adds an extra space when "more lands on a word"

Added gulp-frep because my gulp was adding \r\n wherever \n was present - not sure if it should be doing this?
@bgsavage
Copy link

bgsavage commented Jun 9, 2016

Hi - I've made a pull request for a fix to this issue.

ismarslomic pushed a commit that referenced this issue May 17, 2017
#20 #26 remove whitespace,newlines and tabs in html template
4660d51
@ismarslomic
Copy link
Owner

Solved in 4660d51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yabood @ismarslomic @bgsavage @goclixy-core