Fix noise bandwidth in Numaris/X #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from master
|
This looks OK to me, but we should have @xueh2 / @rajramasawmy / @ahsanjav weigh in since they probably have data to test with. |
|
Just tried this out on our XA60, but the dwell time of the noise (5e-6s) was being set for the acquisition data as well (tested for a range of bandwidths at 2 resolutions) |
|
I'll send the dats to you Kelvin to test |
|
Looks ok to me too. But need phantom test to make sure noise BW is correct. |
|
ignore me this works just fine |
dchansen
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix detection of Numaris/X data and update stylesheet to account for missing imageColumns. This incorporates changes by @xueh2 in #106 , so I'm closing that one.
Prior to this patch, Numaris/X noise dependency data wasn't correctly detected and an incorrect noise bandwidth was returned by compute_noise_sample_in_us().
@ACampbellWashburn @rajramasawmy @ahsanjav I think this sorts out the issue we discussed last week.