Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaflet 1.0-dev support #23

Closed
pawelantczak opened this issue Jul 3, 2015 · 14 comments
Closed

Leaflet 1.0-dev support #23

pawelantczak opened this issue Jul 3, 2015 · 14 comments

Comments

@pawelantczak
Copy link

Hello.

Due to massive api update in Leaflet 1.0, plugin is not working.
Error: Uncaught TypeError: this.callInitHooks is not a function

Do you plan to add support for 1.0?

@ismyrnow
Copy link
Owner

ismyrnow commented Jul 4, 2015

I don't currently use the plugin in any of my apps, so probably not.
However, I am happy to accept a pull request with this functionality, or a
gittip (or similar) to fund the effort.

@dosstx
Copy link

dosstx commented Feb 9, 2016

This is the best plugin out there. I use it for my apps but not smart enough to code the update. Just putting my vote here. If I can help let me know.

@ismyrnow
Copy link
Owner

If anyone is interested in updating this plugin to work with Leaflet v1.0, feel free to open a PR for it. I'll leave the issue open for now.

@arch1v1st
Copy link

+1!

@McCABRUS
Copy link

is someone working on this update?

@ismyrnow
Copy link
Owner

ismyrnow commented Oct 25, 2016 via email

@ismyrnow
Copy link
Owner

It looks like I was mistaken. The PR is for another Leaflet plugin of mine. This one is still up for grabs.

You can also check the existing forks (there are 44 of them right now). It's possible one of them includes a v1 update, and they just haven't opened a PR for it.

@Siliconrob
Copy link

I would think this probably works as a fork of a fork with enhancements for icons is something I am using now for grouped layer controls https://github.com/SGSIMapping/leaflet-sgsilayercontrol and it is working with Leaflet 1.0.1

I could fix this up if you have a specific set of layers you want to test on

@ismyrnow
Copy link
Owner

ismyrnow commented Nov 4, 2016

I'm not sure if that's a fork or a totally different plugin which just has a similar use case. The API is different, so it's probably not a good candidate for a v1 of this plugin.

@Siliconrob
Copy link

Going to give it a shot.

@chugcup
Copy link
Contributor

chugcup commented Nov 8, 2016

I had this requirement in my app so I went ahead and fixed up the code to use the new internal _layers format.

#42

I had another app that still used 0.7.3 so I verified it would maintain backwards-compatibility.

@deeg
Copy link
Contributor

deeg commented Apr 5, 2017

@ismyrnow, can this be closed now that it works with 1.0?

@faipassa
Copy link

faipassa commented Apr 5, 2017

@deeg Look at v0.6.0. It is fully functional with leaflet 1.0

@deeg
Copy link
Contributor

deeg commented Apr 5, 2017

@faipassa, yes I noticed that, which is why I'm saying this issue could be closed so people don't think it doesn't work with 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants