Some suggestions to round out the performance advice #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
requested changes
Apr 12, 2024
Co-authored-by: Jonathan Wakely <github@kayari.org>
Co-authored-by: Jonathan Wakely <github@kayari.org>
Co-authored-by: Jonathan Wakely <github@kayari.org>
Co-authored-by: Jonathan Wakely <github@kayari.org>
Co-authored-by: Jonathan Wakely <github@kayari.org>
updated per suggestions
disgard->discard.
more small corrections.
|
Thanks for the micro-fixes. I don't have an opinion whether it should be merged as-is, I'll leave that to the other editors (I'm semi-retired from this project these days). I do think there's a lot of good content here and some of it would be valuable to use. |
|
I don't even think it should be merged as is. I think it's likely better to cherry pick from the PR and use as they fit. Really what ever easier is fine with me. Some of this section is still rough anyway and it's not like it's cast in stone.. |
|
It's fine, the comments were very helpful and this is hardly *advanced* changes we're talking about here😄
|
added a section on peanut butter costs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this content is very rough. It seemed to me unlikely that I could meet the style and tone that is desired here and also there might be significant disagreement in principle or priority.
Accordingly, I'm willing to work on this PR to the extent that the editors find it useful but I am also happy to let this PR be abandoned or replaced by something it inspires that is more to your liking. You may find it easier to harvest the parts you like, rewrite them in your own style, and then apply them as needed. Perhaps in a different order.
If you would like additional thoughts in one or more areas, feel free to comment and I can add something. I intend this PR to be a discussion tool. I cannot foresee it actually being merged anytime soon if ever.