Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement documentation in Markdown #10

Closed
shalvah opened this issue Jan 17, 2017 · 10 comments
Closed

Implement documentation in Markdown #10

shalvah opened this issue Jan 17, 2017 · 10 comments

Comments

@shalvah
Copy link

shalvah commented Jan 17, 2017

Okay, not really a bug or something, but I feel it would make it easier to read and understand, without having to clone the repo, and on mobile too.

@isocroft
Copy link
Owner

You are very right. Working on this at the moment.

Thanks for the idea.

@shalvah
Copy link
Author

shalvah commented Jan 18, 2017 via email

@isocroft
Copy link
Owner

@shalvah I'll be glad. Please, go ahead. I have just pushed an EASYDOCS.md file which contains a few things. Feel free to update it as necessary.

Thank you so very much for opting to take on this. I appreciate. The load on me concerning this repo is quite enormous.

@shalvah
Copy link
Author

shalvah commented Jan 22, 2017

I noticed this in the easydocs file...

This command will add an entry into the setup.php file inside the routes folder.

                  
   $ php jollof make:route /home GET

Let's now create a simple controller file by running the command below.
This command will drop a Home.php file inside the routes folder.

NOTE: the name of the controller file MUST be the same as the first part of the route url.

   $ php jollof make:controller home

(Forgive any formatting; I'm on mobile.)

So, I'm thinking... Since the controller must be named same as route, why not have a command (or a flag to the route-generating command) that creates the controller file too? I believe he idea behind using commands like these is to simplify things by generating oft-used templates, not just to avoid clicking "New File".

@isocroft
Copy link
Owner

Oh! my bad. I'll correct that error in the EASYDOCS.md file.

Adding a flag to the route-generating command that creates the controller file

I think this's wouldn't be a bad idea. Using one stone to kill two birds. I'll look into this. Infact i'll implement it.

@isocroft
Copy link
Owner

So, now we have the following already implemented - set-controller serves as the flag to create the controller.

    $ php jollof make:route /api/contents/@id POST set-controller

@shalvah what do you think ?

@shalvah
Copy link
Author

shalvah commented Jan 24, 2017 via email

@isocroft
Copy link
Owner

@shalvah, a single letter it is "-c". Will have it done soon

@isocroft
Copy link
Owner

@shalvah , I have already providered 2 alternatives '--controller', '-c'. One is a single-letter flag and the other is a full-option flag (long-option). Pushing v0.0.4 updates in an hours time from now.

@isocroft
Copy link
Owner

on the advice of a developer, who introduced me to https://semver.org, i actually re-versioned Jollof to begin from v0.0.2 (start) -> v0.0.4 (current)

@shalvah shalvah closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants