Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed /src/protected/vendor #14

Closed
wants to merge 1 commit into from
Closed

Removed /src/protected/vendor #14

wants to merge 1 commit into from

Conversation

bystones
Copy link

There should be no need to have this folder in git. Composer should create it on "composer install".

@NegativeIQ
Copy link

Like i said here #26
(I will just copy paste my comment)

Not everyone have or know how to use composer. These way more people with less knowledge can download and run openbay on their websites. And others that are familiar with composer they can update yii framework (and other vendors libraries). I think its even better these way.

@DrOptix
Copy link

DrOptix commented Dec 20, 2014

If you know how to FTP or SSH a server you know how to run a basic bash command. It's no need to pollute the repository with stuff that can be solved with a simple composer install.

@jzjzjzj
Copy link

jzjzjzj commented Dec 21, 2014

Maybe two separate repos are needed - one for proper development, one for distribution (prepacked with vendors etc.)?

@DrOptix
Copy link

DrOptix commented Dec 21, 2014

There is no need for two repos. On github, if I'm not mistaken, when you create a new tag (stable or production ready milestone of the project) you can create both automatic source tars and upload custom tars or zips. Those custom zips can contain a vendor with latest 3rd party libs at the moment of tag creation.

@tvvocold
Copy link

@bystones Hi, can i rm -rf /src/protected/vendor after i install it and test fine?
(what else can i do to speed it up like gzip?)

@jzjzjzj
Copy link

jzjzjzj commented Dec 22, 2014

@tvvocold If you plan to still use the openbay, then no you can not, because those are the dependencies openbay uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants