Revert "style: introduce aliasing, sort imports (#511)" #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 17276df. We are reverting PR #511 because we found out that the outputs of `craco start` and `craco build` were different, resulting in CSS files being imported in an order different to what is intended. The workarounds we found online were convoluted and would introduce unnecessary complexity to the repo. Furthermore, we also found a library (react-app-rewire-alias) which can help us achieve aliasing with CRA as an alternative to Craco. In addition to the bug associated with Craco here, Craco is also overkill since it's a powerful tool which helps users to extend their default CRA configs for webpack among other things. As such, we are reverting this commit and will be attempting to reintroduce aliases at a later date. A sample of how to use react-app-rewire-alias can be found in the vaccinegovsg repo https://github.com/datagovsg/vaccinegovsg-clinic/blob/dev/frontend/config-overrides.js References: - dilanx/craco#57 - DocSpring/craco-antd#12
src/components/HyperlinkModal.jsx
Outdated
| @@ -20,7 +17,7 @@ export default class HyperlinkModal extends Component { | |||
| } | |||
| } | |||
|
|
|||
| changeHandler = (event) => { | |||
| changeHandler(event) { | |||
There was a problem hiding this comment.
We should switch back to arrow function definition because it helps us bind the changeHandler to this automatically.
If we wanted to do away with the arrow function definition, we would have to explicitly write this.handleClick = this.handleClick.bind(this)
There was a problem hiding this comment.
fixed with efcbefc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR reverts PR #511, or commit 17276df.
We are reverting PR #511 because we found out that the outputs of
craco startandcraco buildwere different, resulting in CSS files being imported in an order different to what is intended.The workarounds we found online were convoluted and would introduce unnecessary complexity to the repo. Furthermore, we also found a library (react-app-rewire-alias) which can help us achieve aliasing with CRA as an alternative to Craco. In addition to the bug associated with Craco here, Craco is also overkill since it's a powerful tool which helps users to extend their default CRA configs for webpack among other things.
As such, we are reverting this commit and will be attempting to reintroduce aliases at a later date.
A sample of how to use react-app-rewire-alias can be found in the vaccinegovsg repo https://github.com/datagovsg/vaccinegovsg-clinic/blob/dev/frontend/config-overrides.js
References: