feat(onAuth, onAuthFailure): remove OAuth2 variant, support raw HTTP headers, endless retry, canceling #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/isomorphic-git/isomorphic-git into chore/beta-auth-headers-directly
Test Results for 2bf01bb:
Longest running tests
|
billiegoose
changed the title
Test Results for 4209b9c:
Longest running tests
|
billiegoose
changed the title
Test Results for 1f69ec8:
Longest running tests
|
|
🎉 This PR is included in version 1.0.0-beta.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
modesty
pushed a commit
to modesty/isomorphic-git
that referenced
this pull request
Apr 9, 2024
…s retry, canceling (isomorphic-git#1054) BREAKING CHANGE: The `token` and `oauth2format` properties have been removed from the GitAuth interface, which makes it much simpler and and eliminates a dozen GitErrors handling specific edge cases. A `headers` property has been added to the GitAuth interface. This makes `onAuth` much more powerful because you can inject whatever HTTP headers you want. The `onAuthFailed` callback now lets you return a GitAuth object. This means you can keep retrying to authenticate as many times as you like. A `cancel` property has been added to the GitAuth interface. This means you gracefully give up authenticating and the function will throw an E.UserCancelledError instead of an E.HTTPError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
tokenandoauth2formatproperties have been removed from the GitAuth interface, which makes it much simpler and and eliminates a dozen GitErrors handling specific edge cases.A
headersproperty has been added to the GitAuth interface. This makesonAuthmuch more powerful because you can inject whatever HTTP headers you want.The
onAuthFailedcallback now lets you return a GitAuth object. This means you can keep retrying to authenticate as many times as you like.A
cancelproperty has been added to the GitAuth interface. This means you gracefully give up authenticating and the function will throw an E.UserCancelledError instead of an E.HTTPError.