fix(log): fix error being thrown when using 'filepath' parameter #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a unit test for the fix you made? |
… into fix/git-log-filepath
…omorphic-git into fix/git-log-filepath
|
Added. |
|
Thanks, one more, can you use normal snapshots not embedded in code? |
|
I can, but inline snapshots are used for every other test, this one would be the only one not using them. Do you still want me to replace the inline snapshots? |
|
ok, I didn't realize that the library doesn't use normal snapshots. |
|
One more thing, did you add yourself as a contributor? You can create another PR with your name added. |
|
🎉 This PR is included in version 1.17.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
modesty
pushed a commit
to modesty/isomorphic-git
that referenced
this pull request
Apr 9, 2024
…morphic-git#1589) * fix(log): fix error being thrown when using 'filepath' parameter * add tests for git log when targeting a newly added file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we find the last occurrence of a file in the commit history (not using
forceorfollow), we should try to break first instead of throwing an error.Should fix #1558