Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unchanged image/audio files being queued for commit with git.add() #1908

Closed
marshmn opened this issue May 5, 2024 · 3 comments · Fixed by #1909
Closed

Unchanged image/audio files being queued for commit with git.add() #1908

marshmn opened this issue May 5, 2024 · 3 comments · Fixed by #1909
Labels

Comments

@marshmn
Copy link

marshmn commented May 5, 2024

isomorphic-git: 1.25.8
Node: 20.12.2

This behaviour seems to have changed since upgrading from 1.25.7.

I have a repository with a few modified files (all text files). I'm then running git.add():

await git.add({
    fs,
    dir: this.repoPath,
    filepath: '.'
});

My expectation is that this will add all modified files (only) for commit. However, it is adding not only those files but also some (perhaps all) image and audio files for commit also - even though these are unmodified.

Reverting to 1.25.7 returns to the expected behaviour.

@marshmn
Copy link
Author

marshmn commented May 5, 2024

I've now created a self-contained repo to demonstrate the issue: https://github.com/marshmn/isomorphic-git-1908

@jcubic
Copy link
Contributor

jcubic commented May 5, 2024

This may be the issue with \r character stripping, @jayree can you take a look?

@isomorphic-git-bot
Copy link
Member

🎉 This issue has been resolved in version 1.25.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants