-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: cache .git/index for better performance #787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you wmhilton! I auto-formatted the code using prettier-standard. 🤖 |
Test Results for 563b3e7:
|
Test Results for 563b3e7:
|
Test Results for e365122:
|
Test Results for e365122:
|
Test Results for a3d50e7:
|
🎉 This PR is included in version 0.58.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm improving performance
This speeds up running
statusMatrix
on large repos like https://github.com/ianstormtaylor/slate from ~80 seconds to ~1 second. (These times measured on a proprietary Electron app. How big the perf hit is depends highly on the latency of the filesystem... on Electron the latency is very bad because it is proxied to the worker over IPC.)Possible Dangers
It does caching based on the compound key
[fs, filepathOfIndexFile]
. It useslstat
to determine whether the index file has been modified. 99% of the time this should be enough! However... if you are "resetting" a filesystem mock behind the scenes (like my BrowserFS tests were), that might not be enough. In such cases that the index file returns the samestat
information but it actually has changed different, then your tests may too fail. (This caching may also be susceptible to "racy-git"-like race conditions, since it depends on the last-modified timestamp.)The solution is to make sure whenever you are "resetting" the filesystem to set the filesystem to a new object, i.e.
so that the old cached index file will not be used.