fix: handle no-refs response from git-upload-pack for git > 2.41.0 #1862
Conversation
|
This can't be merged until Unit Tests for Android are fixed. See #1859 |
|
Can you rebase (or |
mojavelinux
force-pushed
the
issue-1860-no-refs-upload-pack-response
branch
from
bb5aff2
to
9b5d925
Compare
|
Done. |
|
Ok, I'm merging the unit tests for this will be added in #1895 (someone provided the same fix, and he added tests). |
|
Next time you should create a branch in this repo, the author of that other PR would be able to create add it to your branch (I think it's called stacked PR). |
|
The release failed. Not sure what to do. @seanpoulter can you take a look? The Job take more than 30 minutes and get stopped by Azure. Here is a link: https://dev.azure.com/isomorphic-git/isomorphic-git/_build/results?buildId=3376&view=results |
|
Is that the first attempt? I'd retry if you can. If you enable timestamps in the logs it seems like our test code was running in the usual amount of time but it stalled after timing out trying to connect to |
|
I clicked rerun failed jobs, I hope it will run everything. |
|
🎉 This PR is included in version 1.25.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Yay, that looks like it worked and updated the website too. I'm going on intuition here but I'd assume it's the |
I dislike that pattern as it pollutes the upstream repo with branches. The typical workflow is to submit PRs from branches. It should be possible to push to that branch if you are a maintainer of this repository. Otherwise, you can submit a PR to that branch and when it is merged, it will be incorporated into the upstream. For me, it's no trouble to be asked to rebase and force push. That is all part of the workflow of a PR in my mind. |
|
I was only thinking to make PR to PR easier. |
* chore(deps-dev): bump express from 4.17.1 to 4.19.2 (#1891) Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.17.1...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: handle no-refs response from git-upload-pack for git > 2.41.0 (#1862) * ci: Add GitHub Workflow * Prevent ERR_OSSL_EVP_UNSUPPORTED on Node >= 17 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Allen <dan.j.allen@gmail.com>
closes #1860