Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new docs when using bundlers #1914

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

lsegurado
Copy link
Contributor

@lsegurado lsegurado commented May 13, 2024

Related to #1855

I'm adding a new command:

  • add as a new file in src/api (and src/commands if necessary)
  • add command to src/index.js
  • update __tests__/test-exports.js
  • create a test in src/__tests__
  • document the command with a JSDoc comment
  • add page to the Docs Sidebar website/sidebars.json
  • add page to the v1 Docs Sidebar website/versioned_sidebars/version-1.x-sidebars.json
  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "feat: Added 'X' command"

@lsegurado lsegurado requested a review from jcubic May 13, 2024 14:31
@jcubic
Copy link
Contributor

jcubic commented May 14, 2024

I think that different bundlers have better ways to include a Buffer object than adding it to a window object directly, but this is better than nothing.

Thanks for your contribution.

@jcubic jcubic merged commit fcaf7cb into isomorphic-git:main May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants