Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper serialisation into JSON and XML #22

Closed
sciguy16 opened this issue Jun 20, 2019 · 0 comments · Fixed by #25
Closed

Proper serialisation into JSON and XML #22

sciguy16 opened this issue Jun 20, 2019 · 0 comments · Fixed by #25

Comments

@sciguy16
Copy link
Collaborator

sciguy16 commented Jun 20, 2019 •
edited

Currently there is no sanitisation or encoding of RequestResponse data when it gets serialised into XML and JSON. A URL or Location header could contain braces or angle brackets, which will mess up the structure. We should implement or derive the Serialize trait properly write unit tests with unusual inputs.

https://github.com/nccgroup/dirble/blob/2eb9801b4083aa2a2181229199d66db899925758/src/output_format.rs#L97-L113
https://github.com/nccgroup/dirble/blob/2eb9801b4083aa2a2181229199d66db899925758/src/output_format.rs#L116-L134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved serialisation sciguy16/dirble
1 participant
@sciguy16