Include original stacktrace when query fails #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks great, thanks! |
|
Updated changelog and bumped version, published as 2.4.2 |
|
@isoos Great! I've just noticed I missed deleting a print statement on test file 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@isoos Hello! I've come up with a solution for the stacktrace issue.
Since a queue is used to resolve the queries, we cannot simply include the
StackTraceat the location ofCompleter.completeError, so when creating theQueryobject, theStackTraceat that time is attached. That way, when the error happens, we can use that one instead.I don't know if there is a better way to do this kind of
StackTracehandling, but with this (maybe naive) solution we get the exact line that caused the error.