Dispose closed pool connections

[nehzata]

In some cases the connection gets closed after a query is executed without throwing an error. This patch checks to see if the connection has been closed and disposes of it.

steps to replicate:

final conn = Pool.withEndpoints(....);
await conn.execute('-- test'); // this doesn't throw but it causes the connection to close
await conn.execute('select true'); // this throws because the pool picks up the previously closed connection. a PgException(Severity.error Connection is closing down) error is thrown. 

[isoos]

Thanks, looks good! Would you happen to have time to also update the changelog and maybe add a test case for this?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4240b5d) 85.73% compared to head (daa9d57) 85.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
+ Coverage   85.73%   85.77%   +0.04%     
==========================================
  Files          25       25              
  Lines        2215     2215              
==========================================
+ Hits         1899     1900       +1     
+ Misses        316      315       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nehzata]

@isoos Thanks for the quick response. PR updated. Let me know if anything else is needed.

[nehzata]

Nice! Thanks @isoos. Apologies I was in a rush with the kids. Appreciate your help.

[isoos]

How urgent is this fix to get published? I have a few things in mind to also add, but may not have the time to do it all. Maybe wait a few more days before it gets out?

[nehzata]

🙏 No trouble. I can hang a few days. Let me know if I can help in any way.

[isoos]

Published in 3.0.2.