Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Config lost too early and produces wrong currency #1590

Closed
tsarma opened this issue Dec 29, 2015 · 2 comments
Closed

Store Config lost too early and produces wrong currency #1590

tsarma opened this issue Dec 29, 2015 · 2 comments
Labels
Milestone

Comments

@tsarma
Copy link
Contributor

tsarma commented Dec 29, 2015

screen-shot-2015-12-29-at-09 14 14

As seen in the pic. above invoice has 2 different currencies shown. which is wrong.

I've set up 2 stores with CHF (default store), EUR as currency. Products are shown with CHF price. With store config switcher one can change the price to EUR.

When I add place some products in cart and oder it. Through out the checkout process currency is shown correctly when I switch store from CHF to EUR and vice versa. Even on the order review page currency is show correct with what ever I have chosen.

But inside the mail ##cart_html## and ##document## currency is shown wrong.

Inside method formatPriceWithCurrency https://github.com/isotope/core/blob/master/system/modules/isotope/library/Isotope/Isotope.php#L303 store config gets value of default store $objConfig = static::getConfig();

In the backend, Isotope orders - currencies are show correctly.

This was referenced Dec 31, 2015
@tsarma
Copy link
Contributor Author

tsarma commented Dec 31, 2015

With these changes in pull request, I was able to solve the issue.

https://github.com/tsarma/develop/commit/cce498021d1b8756ee9b7b7ae0c42e9cc4734eca

https://github.com/tsarma/develop/commit/21bd05129fdc3bc6ff2bd1bc5ed9ce7a34a093ac

But please see if these changes are worthwhile.

@aschempp aschempp added the bug label Jan 3, 2016
@aschempp aschempp added this to the 2.3.3 milestone Jan 3, 2016
@tsarma
Copy link
Contributor Author

tsarma commented Jan 4, 2016

There is related issue. Actually, I think this one is duplicate of #1559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants