-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product to group not possible #2131
Comments
I have fixed the |
This was referenced May 11, 2020
see contao/contao#1728 for the bugfix in Contao about |
leofeyer
pushed a commit
to contao/contao
that referenced
this issue
May 11, 2020
Description ----------- | Q | A | -----------------| --- | Fixed issues | isotope/core#2131, isotope/core#2140 As discussed on Slack, `fastcgi_finish_request` (and other output buffer methods) break our logic of simulating a kernel request/response behavior. As @ausi suggested, we're not removing the `Template::flushAllData()` method (because it is public), but we shouldn't flush the data anymore on `Template::output()`. Commits ------- 81a5712 Do not flush the template output buffer
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this issue
May 11, 2020
Description ----------- | Q | A | -----------------| --- | Fixed issues | isotope/core#2131, isotope/core#2140 As discussed on Slack, `fastcgi_finish_request` (and other output buffer methods) break our logic of simulating a kernel request/response behavior. As @ausi suggested, we're not removing the `Template::flushAllData()` method (because it is public), but we shouldn't flush the data anymore on `Template::output()`. Commits ------- 81a57127 Do not flush the template output buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Contao:
4.9.2
Isotope:
2.6.10
When I want to add a group to a product a popup opens with no inner content looking like this
I tracked it down to this line
https://github.com/contao/contao/blob/b9c1002fb70588936db66415dbfa286fd11617f6/core-bundle/src/Resources/contao/library/Contao/Template.php#L678
if i comment this out it works fine.
Also I noticed that when I want to set a group to multiple products at once they will be set to
gid=0
. I could fix it by replacing this linecore/system/modules/isotope/library/Isotope/Backend.php
Line 286 in c77fc8d
with
\Controller::reload();
The text was updated successfully, but these errors were encountered: