Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product to group not possible #2131

Closed
michb opened this issue Apr 14, 2020 · 2 comments
Closed

Add product to group not possible #2131

michb opened this issue Apr 14, 2020 · 2 comments
Labels
Milestone

Comments

@michb
Copy link
Contributor

michb commented Apr 14, 2020

Contao: 4.9.2
Isotope: 2.6.10

When I want to add a group to a product a popup opens with no inner content looking like this
iso_group
I tracked it down to this line

https://github.com/contao/contao/blob/b9c1002fb70588936db66415dbfa286fd11617f6/core-bundle/src/Resources/contao/library/Contao/Template.php#L678
if i comment this out it works fine.

Also I noticed that when I want to set a group to multiple products at once they will be set to gid=0. I could fix it by replacing this line

with \Controller::reload();

@aschempp aschempp added the bug label May 8, 2020
@aschempp aschempp added this to the 2.6.11 milestone May 8, 2020
@aschempp
Copy link
Member

aschempp commented May 8, 2020

I have fixed the exit statement in 799a28e. Not sure about the fastcgi_finish_request , that probably needs to be fixed in Contao.

@aschempp
Copy link
Member

see contao/contao#1728 for the bugfix in Contao about fastcgi_finish_request.

leofeyer pushed a commit to contao/contao that referenced this issue May 11, 2020
Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | isotope/core#2131, isotope/core#2140


As discussed on Slack, `fastcgi_finish_request` (and other output buffer methods) break our logic of simulating a kernel request/response behavior. As @ausi suggested, we're not removing the `Template::flushAllData()` method (because it is public), but we shouldn't flush the data anymore on `Template::output()`.

Commits
-------

81a5712 Do not flush the template output buffer
leofeyer pushed a commit to contao/core-bundle that referenced this issue May 11, 2020
Description
-----------

| Q                | A
| -----------------| ---
| Fixed issues     | isotope/core#2131, isotope/core#2140


As discussed on Slack, `fastcgi_finish_request` (and other output buffer methods) break our logic of simulating a kernel request/response behavior. As @ausi suggested, we're not removing the `Template::flushAllData()` method (because it is public), but we shouldn't flush the data anymore on `Template::output()`.

Commits
-------

81a57127 Do not flush the template output buffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants