Dots in translation keys in tl_iso_config.xlf

[ameotoko]

This DCA definition has dots in options array elements, which means their respective translations had dots in translation keys before 2f713ff.

core/system/modules/isotope/dca/tl_iso_config.php

Lines 513 to 519 in 175a07f

	'currencyProvider' => array
	(
	'exclude' => true,
	'inputType' => 'select',
	'options' => array('ecb.int', 'admin.ch'),
	'reference' => &$GLOBALS['TL_LANG']['tl_iso_config'],
	'eval' => array('mandatory'=>true, 'tl_class'=>'w50'),

However, after converting to XLIFF in 2f713ff, this now is invalid, because XLIFF loader loads this like $GLOBALS['TL_LANG']['tl_iso_config']['currencyProvider']['ecb']['int'] instead of ['ecb.int']:

core/system/modules/isotope/languages/en/tl_iso_config.xlf

Lines 362 to 367 in 175a07f

	<trans-unit id="tl_iso_config.ecb.int">
	<source>European Central Bank</source>
	</trans-unit>
	<trans-unit id="tl_iso_config.admin.ch">
	<source>Swiss Federal Department of Finance</source>
	</trans-unit>

The most obvious fix is probably replace ecb.int with ecb_int, but it would require migration, and I am not familiar with runonce system...

[aschempp]

Can't we escape the name in the language file to tl_iso_config.admin\.ch?

[ameotoko]

Escaping does not work in .xlf files, but it's possible to have a tl_iso_config.php file with just these two translations, along with tl_iso_config.xlf storing everything else. This works.

[aschempp]

I have applied a fix in a4148a8. Since we still handle the old DB values in the automater, and update would not break anything and a migration is not really necessary imho. You would need to select a new value when editing a config, but that's fine with me. Let me know if you disagree 🙃

[ameotoko]

LGTM :)