Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explanation for uploadable attributes #2322

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Fix explanation for uploadable attributes #2322

merged 1 commit into from
Jul 13, 2022

Conversation

ameotoko
Copy link
Contributor

This fixes invalid translation element for explanation popup, when editing fields checkoutTargetFolder or checkoutTargetFile in product attribute of type File Upload or FineUploader.

Before:
Screenshot 2022-07-12 at 21 11 04

After:
Screenshot 2022-07-12 at 23 22 29

@ameotoko ameotoko changed the title fix explanation for uploadable attributes Fix explanation for uploadable attributes Jul 12, 2022
@aschempp aschempp added the bug label Jul 13, 2022
@aschempp aschempp added this to the 2.8.6 milestone Jul 13, 2022
@aschempp aschempp merged commit 2be2edf into isotope:2.8 Jul 13, 2022
@aschempp
Copy link
Member

Thank you @ameotoko

@ameotoko ameotoko deleted the fix/explanation branch July 13, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschempp aschempp aschempp approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.8.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ameotoko @aschempp