Add handling for sorting by variant attributes #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting approach. This only works if there is a default variant though, right? |
|
You are right, I had the products without an default variant not in mind :-( ... I see there two approaches to handle them.
Maybe you have more suggestions with your experience in isotope :-) |
|
I have updated the PR to simplify things. If there IS a default variant, we will use your new approach which should work fine. If there is none, we simply continue with the old version (basically using an empty value). Are you ok with that? |
|
Yes, I'm absolutely okay with that. Thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here the sorting by variant attributes is not implemented yet: #2375
This pull request is a proposal to add sorting by variant attributes. I'm not really sure that this solves all cases, so it would be very nice to get some feedback :-)