Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C4 003 Adaption towards Contao 5 #2491

Closed
wants to merge 2 commits into from
Closed

C4 003 Adaption towards Contao 5 #2491

wants to merge 2 commits into from

Conversation

Ernestopheles
Copy link

Next adaption towards Contao 5.

See useCases tested with cypress: tests
Contao 4.13.31, Isotope 2.9 and PHP 8.1

Copy link
Contributor

@fritzmg fritzmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling

System::getContainer()->get('contao.routing.scope_matcher')
System::getContainer()->get('request_stack')

every time I think you should put

$container = System::getContainer();
$scopeMatcher = $container->get('contao.routing.scope_matcher');
$requestStack = $container->get('request_stack');

At the beginning of the file and then re-use the variables.

@Ernestopheles
Copy link
Author

Thank you, @fritzmg, absolutely right

@Ernestopheles
Copy link
Author

I replaced this PR by PR C4 004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants