Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional setting to prevent force-show first order column in backend #2527

Open
wants to merge 1 commit into
base: 2.8
Choose a base branch
from
Open

Add optional setting to prevent force-show first order column in backend #2527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions system/modules/isotope/drivers/DC_ProductData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1484,7 +1484,7 @@ protected function listView()
<table class="tl_listing' . (($GLOBALS['TL_DCA'][$this->strTable]['list']['label']['showColumns'] ?? null) ? ' showColumns' : '') . ($this->strPickerFieldType ? ' picker unselectable' : '') . '">';

// Automatically add the "order by" field as last column if we do not have group headers
if ($GLOBALS['TL_DCA'][$this->strTable]['list']['label']['showColumns'] ?? null)
if (($GLOBALS['TL_DCA'][$this->strTable]['list']['label']['showColumns'] ?? null) && false !== ($GLOBALS['TL_DCA'][$this->strTable]['list']['label']['showFirstOrderBy'] ?? null))
{
$blnFound = false;

Expand Down Expand Up @@ -2121,7 +2121,7 @@ protected function parentView()
<table class="tl_listing' . ($GLOBALS['TL_DCA'][$this->strTable]['list']['label']['showColumns'] ? ' showColumns' : '') . '">';

// Automatically add the "order by" field as last column if we do not have group headers
if ($GLOBALS['TL_DCA'][$this->strTable]['list']['label']['showColumns'] ?? null) {
if (($GLOBALS['TL_DCA'][$this->strTable]['list']['label']['showColumns'] ?? null) && false !== ($GLOBALS['TL_DCA'][$this->strTable]['list']['label']['showFirstOrderBy'] ?? null)) {
$blnFound = false;

// Extract the real key and compare it to $firstOrderBy
Expand Down