-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Die Funktion findPrice() wird für jede Produktvariation geladen. #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odukt in der möglichen Prodktvariante existiert. Die doppelte initialisierung der Klasse ist aber noch vorhanden. FindPrice wird nicht benötigt um min- und max-Preis zu erfahren.
…ötigt wird und daher hier nicht eingetragen ist.
… Preis, ... geladen werden, daher weg damit. spart performence. z.B. beim Checkout
Ich kann den Pull Request leider so nicht übernehmen. Nichtsdestotrotz schau ich mir das natürlich direkt in deinem Repo an ;-) |
ghost
mentioned this pull request
Jan 7, 2013
Closed
aschempp
pushed a commit
that referenced
this pull request
Jan 3, 2014
Feature/model registry develop
Closed
This was referenced May 6, 2014
This was referenced May 3, 2015
This was referenced Oct 12, 2015
Closed
ghost
mentioned this pull request
Feb 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dieser Workaround holt den Preis für das Produkt erst, wenn dieses vollständig konfiguriert ist. Dadurch werden die DB-Abfragen auf ein Minimum reduziert.
Bisher gab es in meinem Testsenario 1000 Produktvariationen zu einem Produkt. Dadurch erfolgten 1000 DB-Abfragen obwohlt bisher nur der Min- bzw. Max-Preis benötigt wurde.
Diese werden weiterhin eingelesen, doch erst wenn das Produkt in der Variante konfiguriert wurde erfolgt die Abfrage, die den Preis besorgt.
ANMERKUNG: Ticket #3186 mit der doppelten Initialisierung der Klasse ist hierdurch noch nicht behoben.