Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalize cached file handling #115

Closed
4 tasks done
sebkopf opened this issue Apr 8, 2020 · 1 comment
Closed
4 tasks done

finalize cached file handling #115

sebkopf opened this issue Apr 8, 2020 · 1 comment

Comments

@sebkopf
Copy link
Contributor

sebkopf commented Apr 8, 2020

  • cached files are not currently transferrable, probably because file_root is included in the file hash, don't include it in the hash or figure out why else the caching doesn't work across different file locations
  • cached file names should have the file ID in the filename
  • there should be a flag in reread_files that allows reread_erroneous_only = TRUE to make it easy to reread erroneous files only in a collection. this replaces the much less useful cache_files_with_errors parameter which achieves the same but has to be called on the original read rather than when re-reading from cache (the more likely practical scenario)
  • update handling of different isoreader file versions when reading from .rds, only do backwards compatibility checks if version differences require it to speed up read time (give a warning along the lines of some files were read with an older version of isoreader and require backwards compatibility checks - to avoid this warning, reread_...
sebkopf added a commit that referenced this issue Apr 27, 2020
sebkopf added a commit that referenced this issue Apr 27, 2020
use iso_reread_files_with_problems() instead, part of #115
sebkopf added a commit that referenced this issue Apr 27, 2020
@sebkopf
Copy link
Contributor Author

sebkopf commented Apr 29, 2020

full implement in version 1.2.0

@sebkopf sebkopf closed this as completed Apr 29, 2020
sebkopf added a commit that referenced this issue Jul 5, 2020
sebkopf added a commit that referenced this issue Jul 5, 2020
use iso_reread_files_with_problems() instead, part of #115
sebkopf added a commit that referenced this issue Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant