[opaque pointers 2] Removed usage of getElementPointerType from opt.cpp #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneshlya
force-pushed
the
opaque_ptrs_opt
branch
from
861c7a9
to
960758d
Compare
aneshlya
changed the title
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prepares ISPC code base to support opaque pointers mode.
NOTE: there is a bunch of functions related to the processing of our pseudo gathers/pseudo scatters intrinsics where the base pointer element type is always int8. There is no way to get it from the function signature in opaque mode, so I'm keeping it in the constructors of helper structures.