Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ISPC build with opaque pointers in GA #2377

Merged
merged 3 commits into from Sep 26, 2022
Merged

Enable ISPC build with opaque pointers in GA #2377

merged 3 commits into from Sep 26, 2022

Conversation

aneshlya
Copy link
Collaborator

  • Removed -Wno-deprecated-declarations option from ISPC build
  • Enabled ISPC_OPAQUE_PTR_MODE for ISPC build with LLVM 15.0 in GA
  • Fixed load_unaligned and bool_swizzle tests for opaque pointers

@aneshlya aneshlya force-pushed the aneshlya/enable_opaque_ptrs_ci branch from 58c157c to fb02a25 Compare September 23, 2022 23:12
@aneshlya aneshlya force-pushed the aneshlya/enable_opaque_ptrs_ci branch from fb02a25 to 112806c Compare September 23, 2022 23:17
dbabokin
dbabokin approved these changes Sep 24, 2022
View reviewed changes
Copy link
Collaborator

@dbabokin dbabokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbabokin dbabokin merged commit 5d644aa into ispc:main Sep 26, 2022
@aneshlya aneshlya mentioned this pull request Oct 18, 2022
Closed
@aneshlya aneshlya deleted the aneshlya/enable_opaque_ptrs_ci branch March 17, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbabokin dbabokin dbabokin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aneshlya @dbabokin