Add dirty check #157
Merged
Add dirty check #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 28, 2021 15:27
RickLucassen
requested review from
randywanga,
MarkdenToom-isp and
RubenvandeKerkhof-isp
RubenvandeKerkhof-isp
approved these changes
Sep 30, 2021
randywanga
reviewed
Oct 5, 2021
src/field-accessor.ts
Outdated
| return false; | ||
| } | ||
| if (Array.isArray(this.value)) { | ||
| return toJS(this.value).length !== this._originalValue.length; |
There was a problem hiding this comment.
Is this a proper dirty check? Because it looks like it only checks if the array is equal in length. So if I change one value in the array but keep it the same length, will it correctly flag as dirty?
There was a problem hiding this comment.
Good catch! I came across this issue while implementing the restore functionality.
This has been fixed in that PR by comparing the values in its stringified form when the lengths are the same.
randywanga
approved these changes
Oct 5, 2021
MarkdenToom-isp
approved these changes
Oct 5, 2021
Revert state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality for dirty checks on accessors.
For each accessor the initial value (this also includes any value through
addModeDefaults) is saved and compared to see if this has been changed ever since.After a succesful save of the
FormAccessorthe initial value is updated and thus the dirty state is reset.Each
accessorhas aisDirtyproperty to check for this state, also aresetDirtyStateis present on eachaccessorto reset this manually.